Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/transparent png #1547 #1690

Merged
merged 7 commits into from
Sep 18, 2019
Merged

Bugfix/transparent png #1547 #1690

merged 7 commits into from
Sep 18, 2019

Conversation

Jordaneisenburger
Copy link
Member

@Jordaneisenburger Jordaneisenburger commented Sep 16, 2019 •
edited
Loading

Description

Update to latest version of express-sharp v2.1.2

Verification Steps

  • Upload .png image to magento backend product
  • Go to product page.
  • Check if image has transparent background

Closes #1547.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Sep 16, 2019 •
edited
Loading

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 7ba6682

@zetlen zetlen self-requested a review September 16, 2019 16:10
zetlen
zetlen suggested changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@zetlen zetlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Jordaneisenburger, if you run a full yarn install at repo root, it should make some changes to yarn.lock. Can you commit those too?

@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label Sep 16, 2019
@Jordaneisenburger
Copy link
Member Author

@zetlen oopsie my bad, done.

@sirugh sirugh self-assigned this Sep 17, 2019
@sirugh
Copy link
Contributor

sirugh commented Sep 17, 2019

@Jordaneisenburger just to clarify when you say upload a png you mean one with a transparent background right?

sirugh
sirugh approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Develop clearly shows the wrong background, after yarn install on this PR I can change background color and the transparency is working.

@Jordaneisenburger
Copy link
Member Author

@Jordaneisenburger just to clarify when you say upload a png you mean one with a transparent background right?

Correct.

@sirugh sirugh requested a review from zetlen September 18, 2019 14:00
@dpatil-magento dpatil-magento merged commit 46103cb into magento:develop Sep 18, 2019
@dpatil-magento dpatil-magento mentioned this pull request Oct 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirugh sirugh sirugh approved these changes

@zetlen zetlen Awaiting requested review from zetlen

Assignees

@sirugh sirugh

Labels
Partner: Experius partners-contribution pkg:pwa-buildpack version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: png's with transparent background are changed to black background
6 participants
@Jordaneisenburger @PWAStudioBot @sirugh @zetlen @magento-engcom-team @dpatil-magento