Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes errant debugger statement in tests #1353

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

supernova-at
Copy link
Contributor

@supernova-at supernova-at commented Jun 14, 2019

Description

There was a debugger statement in a test file which would pause test execution in debug mode.

Related Issue

Closes #N/A, quick fix. I know I shouldn’t do this. I WONT REPEAT THIS, I swear it by the old gods and the new

Verification Steps

yarn test

How have YOU tested this?

  1. yarn test

Screenshots / Screen Captures (if appropriate):

Proposed Labels for Change Type/Package

  • major (e.g x.0.0 - a breaking change)
  • minor (e.g 0.x.0 - a backwards compatible addition)
  • patch (e.g 0.0.x - a bug fix)

Checklist:

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@vercel
Copy link

vercel bot commented Jun 14, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://venia-git-supernova-removedebugger.magento-research1.now.sh

@PWAStudioBot
Copy link
Contributor

Fails
🚫 Missing "Verification Steps" section. Please add it back, with detail.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" in your PR.

🚫 A version label is required. A maintainer must add one.
Messages
📖 We are currently working on automating the PR metadata checks. Until that time, you may see failures related to labels/description/linked issues/etc even if you have fixed the problem. Failures will persist until the next push (assuming they are fixed).

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against fe9d81e

@supernova-at supernova-at added the version: Patch This changeset includes backwards compatible bug fixes. label Jun 14, 2019
Copy link
Contributor

@tjwiebell tjwiebell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛

@tjwiebell tjwiebell merged commit 1be1ab9 into develop Jun 14, 2019
@supernova-at supernova-at deleted the supernova/remove_debugger branch July 25, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-concept version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants