Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev]: Minor changes to the templates. Also added a doc change issue template #1077

Merged
merged 6 commits into from
Mar 28, 2019

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented Mar 27, 2019

Description

Updates the PR template, issue templates, and adds a doc change issue template!

Related Issue

Closes #1076

Verification Steps

Read through these changes. Throw them in a Markdown viewer and see if my markdown is correct. Let me know if any of them need more tinkerin!

How Have YOU Tested this?

Now that you mention it... I haven't since I can't actually use these templates without merging them!

Proposed Labels for Change Type/Package

  • major (e.g x.0.0 - a breaking change)
  • minor (e.g 0.x.0 - a backwards compatible addition)
  • patch (e.g 0.0.x - a bug fix)

Although this is github stuff so probably not really necessary to put in a release.

Checklist:

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@vercel
Copy link

vercel bot commented Mar 27, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

.github/ISSUE_TEMPLATE/doc_change.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/doc_change.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/doc_change.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/doc_change.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/doc_change.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/doc_change.md Show resolved Hide resolved
@vercel vercel bot temporarily deployed to staging March 28, 2019 14:14 Inactive
@vercel vercel bot temporarily deployed to staging March 28, 2019 14:15 Inactive
@coveralls
Copy link

coveralls commented Mar 28, 2019

Coverage Status

Coverage remained the same at 76.533% when pulling 8f7d3c3 on template-tinkerin into 7a95721 on develop.

@sirugh sirugh merged commit 8ec1b76 into develop Mar 28, 2019
@sirugh sirugh deleted the template-tinkerin branch March 28, 2019 17:42
@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the github templates!
4 participants