-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates PR Template to include Version label #1048
Updates PR Template to include Version label #1048
Conversation
This pull request is automatically deployed with Now. |
…ng a version change label.
17515fb
to
404580a
Compare
I added / fixed up a couple other minor things in the PR Template while I was in there. I don't know how / that we're using the answers to the "Proposed Labels for Change Type/Package" question, so that could be a good one to drop. That change seemed out of scope for this ticket though. |
I agree with dropping the labels/package question. I also propose dropping the last two checkbox items as they will never be checked on initial create. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but wanted to check if we want to sneak the removal of those two loosely used checkboxes in the scope of this PR. I'm leaning towards no, and we just merge. @supernova-at, agree?
Description
This PR updates our pull request template to add a checklist step for PR authors to propose a SemVer change level of their changes (patch, minor, major).
Related Issue
Closes #1047 .
Motivation and Context
We'd like to determine MAJOR, MINOR, or PATCH changes at the PR level while we have context into the change instead of at release time when it will be easier to forget or miss the impact of a change.
Three new labels exist for this purpose:
version: Major
version: Minor
version: Patch
To get PR authors to add these labels, this PR adds a step to the PR checklist.
Verification
Reading the new PR Template for accuracy.
How Has This Been Tested?
n/a
Screenshots (if appropriate):
Proposed Labels for Change Type/Package
DOCUMENTATION
n/a
Checklist: