-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Add / to graphql validation endpoint #1045
Conversation
This pull request is automatically deployed with Now. |
This is a good addition, but it's a reminder to me that we need proper URI construction as part of UPWARD. |
Yea I felt like its sort of papering over an issue but |
Just tested this out, and ⚠ request to https://m2pwa.test//graphql failed, reason: unable to verify the first certificate Opening I tried changing I'm working off "pwastudio :: develop" branch. Any ideas? |
@brendanfalkowski I've not seen the certificate error before. I think that is unrelated to this fix. Open an issue please! |
Description
The graphql validation endpoint we added in #1004 did not have a
/
. Since we don't mandate that theMAGENTO_BACKEND_URL
end with a forward slash we should add one here to be safe.Motivation and Context
Verification
To verify, set the
MAGENT_BACKEND_URL
in your.env
to something without a/
likeMAGENTO_BACKEND_URL="https://release-dev-231-npzdaky-zddsyhrdimyra.us-4.magentosite.cloud"
Then from root run
yarn run validate-queries
. It should fail.Then check out this PR and run it again, and it should pass.
How Has This Been Tested?
Above verification. Also tested with url ending with
/
.Screenshots (if appropriate):
Proposed Labels for Change Type/Package
Checklist: