Fix makeUrl for Fastly

[jimbo]

Description

Fix makeUrl for Fastly image optimization.

Related Issue

• Fastly Image optimization not working with Upward PHP. #1038

Motivation and Context

URLs from GraphQL are now absolute, and they include the media path logic we currently have in makeUrl. So we need to remove this logic and rewrite what remains to be compatible with absolute URLs. Also, we need to enable Fastly image optimization in certain environments.

Verification

• Ensure category images are loading on the home page
• Ensure you can soft navigate (click) from home page to a category page
• Ensure product images are loading in the category gallery
• Ensure you can soft navigate from a category page to a product page
• Ensure product images are loading
• Ensure you can soft navigate to the home page via the header logo

How Has This Been Tested?

• UAT with the above method, image optimization enabled
• UAT with the above method, image optimization disabled, Fastly enabled
• yarn test

[vercel]

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

[jimbo]

Could add memoization back at some point, but it should take useFastly into account.

[zetlen]

Of course, it was the memoization. Should have figured that out.

[tjwiebell]

Ran local QA with imageOpt disabled and verified:

• All images ran through Fastly IO when USE_FASTLY=1
• Images returned as full size when USE_FASTLY is unset or USE_FASTLY=0

LGTM 👍

[tjwiebell]

Change looks even better with a descriptive docblock, nice add @sirugh.