Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Post-install script should stop suggesting custom origin setup once it's complete #1731

Closed
1 of 7 tasks
zetlen opened this issue Sep 21, 2019 · 1 comment · Fixed by #1734
Closed
1 of 7 tasks
Labels
bug Something isn't working Effort: 1-Small Estimated to be a small effort for a community developer, doable by a beginner. Event: cdmunich19 Groomed for Munich Contribution Day 2019 help wanted Eligible for community contribution. pkg:pwa-buildpack Progress: good first issue Good for newcomers

Comments

@zetlen
Copy link
Contributor

zetlen commented Sep 21, 2019

Describe the bug
When checking out and installing dependencies, a post-install script runs which logs:

$ node scripts/monorepo-introduction.js
Preparing packages...
Set up a custom origin for your copy of venia-concept:
	yarn buildpack create-custom-origin packages/venia-concept

It continues to log that custom origin notice even after you have run the command. It should detect that you've already run the command and stop logging.

To Reproduce
Steps to reproduce the behavior:

  1. From repository root, run yarn run watch:venia.
  2. If necessary, go through the steps and set up a custom origin. Then run yarn run watch:venia again, to observe the dev server starting and binding to the custom domain.
  3. Quit the dev server.
  4. Run yarn install.

Expected behavior
After install, the system should recognize that your repo is already set up. It should do no logging beyond "Preparing packages".

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
This is a recent addition to scripts/monorepo-introduction.js that exposes a small bug in Buildpack's configureHost function. It's a good first issue for community developers who want to work on tooling.

Possible solutions

  • Modify configureHost.js so it always builds its hash from the absolute directory path.
  • Modify monorepo-introduction.js so it always passes an absolute directory path to configureHost().
    The first is probably better.

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
@zetlen zetlen added bug Something isn't working help wanted Eligible for community contribution. Progress: good first issue Good for newcomers pkg:pwa-buildpack Event: cdmunich19 Groomed for Munich Contribution Day 2019 Effort: 1-Small Estimated to be a small effort for a community developer, doable by a beginner. labels Sep 21, 2019
LukasKiederle added a commit to LukasKiederle/pwa-studio that referenced this issue Sep 21, 2019
…stom origin when the project was already setup like this (magento#1731)
@LukasKiederle
Copy link
Contributor

I am currently working on it

LukasKiederle added a commit to LukasKiederle/pwa-studio that referenced this issue Sep 21, 2019
…stom origin when the project was already setup like this. (magento#1731)
zetlen pushed a commit that referenced this issue Sep 21, 2019
…stom origin when the project was already setup like this. (#1731) (#1734)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Effort: 1-Small Estimated to be a small effort for a community developer, doable by a beginner. Event: cdmunich19 Groomed for Munich Contribution Day 2019 help wanted Eligible for community contribution. pkg:pwa-buildpack Progress: good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants