[bug]: Post-install script should stop suggesting custom origin setup once it's complete #1731
Closed
1 of 7 tasks
Labels
bug
Something isn't working
Effort: 1-Small
Estimated to be a small effort for a community developer, doable by a beginner.
Event: cdmunich19
Groomed for Munich Contribution Day 2019
help wanted
Eligible for community contribution.
pkg:pwa-buildpack
Progress: good first issue
Good for newcomers
Describe the bug
When checking out and installing dependencies, a post-install script runs which logs:
It continues to log that custom origin notice even after you have run the command. It should detect that you've already run the command and stop logging.
To Reproduce
Steps to reproduce the behavior:
yarn run watch:venia
.yarn run watch:venia
again, to observe the dev server starting and binding to the custom domain.yarn install
.Expected behavior
After install, the system should recognize that your repo is already set up. It should do no logging beyond "Preparing packages".
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
This is a recent addition to
scripts/monorepo-introduction.js
that exposes a small bug in Buildpack'sconfigureHost
function. It's a good first issue for community developers who want to work on tooling.Possible solutions
configureHost.js
so it always builds its hash from the absolute directory path.monorepo-introduction.js
so it always passes an absolute directory path toconfigureHost().
The first is probably better.
Please let us know what packages this bug is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
The text was updated successfully, but these errors were encountered: