- Use value instead of casting false to null

- Update tests
magento · Feb 5, 2020 · f9a3c8e · f9a3c8e
1 parent 23e9cb5
commit f9a3c8e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/...rtPage/PriceAdjustments/ShippingMethods/__tests__/__snapshots__/shippingForm.spec.js.snap b/...rtPage/PriceAdjustments/ShippingMethods/__tests__/__snapshots__/shippingForm.spec.js.snap
@@ -164,7 +164,6 @@ Array [
     </div>
     <button
       className="root_normalPriority"
-      disabled={null}
       type="submit"
     >
       <span
@@ -213,7 +212,7 @@ Array [
         >
           <select
             className="input"
-            disabled={null}
+            disabled={false}
             name="country"
             onBlur={[Function]}
             onChange={[Function]}
@@ -355,7 +354,6 @@ Array [
     </div>
     <button
       className="root_normalPriority"
-      disabled={null}
       type="submit"
     >
       <span
@@ -404,7 +402,7 @@ Array [
         >
           <select
             className="input"
-            disabled={null}
+            disabled={false}
             name="country"
             onBlur={[Function]}
             onChange={[Function]}
@@ -588,7 +586,6 @@ Array [
     </div>
     <button
       className="root_normalPriority"
-      disabled={null}
       type="submit"
     >
       <span
@@ -637,7 +634,7 @@ Array [
         >
           <select
             className="input"
-            disabled={null}
+            disabled={false}
             name="country"
             onBlur={[Function]}
             onChange={[Function]}
@@ -859,7 +856,7 @@ Array [
         >
           <select
             className="input"
-            disabled={null}
+            disabled={false}
             name="country"
             onBlur={[Function]}
             onChange={[Function]}

diff --git a/packages/venia-ui/lib/components/CartPage/PriceAdjustments/ShippingMethods/shippingForm.js b/packages/venia-ui/lib/components/CartPage/PriceAdjustments/ShippingMethods/shippingForm.js
@@ -58,7 +58,7 @@ const ShippingForm = props => {
                     classes={{ root: classes.country }}
                 >
                     <Select
-                        disabled={isCountriesLoading ? true : null}
+                        disabled={isCountriesLoading}
                         field="country"
                         items={countries}
                         onValueChange={handleCountryChange}
@@ -82,7 +82,7 @@ const ShippingForm = props => {
                 {!hasMethods ? (
                     <Button
                         classes={{ root_normalPriority: classes.submit }}
-                        disabled={setShippingLoading ? true : null}
+                        disabled={setShippingLoading}
                         priority="normal"
                         type="submit"
                     >