Skip to content

Commit

Permalink
update custom domain to reserved DNS label .localhost
Browse files Browse the repository at this point in the history
  • Loading branch information
sharkySharks committed Feb 8, 2019
1 parent 17d4a6a commit 3d1bdf0
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docker/.env.docker
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ MAGENTO_BUILDPACK_PROVIDE_SECURE_HOST=0
PWA_STUDIO_PORTS_DEVELOPMENT=8080
PWA_STUDIO_HOST_DEVELOPMENT=localhost
# match PWA_STUDIO_PUBLIC_PATH value with the --host value of the "watch:docker" script in packages/venia-concept/package.json
PWA_STUDIO_PUBLIC_PATH=pwa-docker.local
PWA_STUDIO_PUBLIC_PATH=pwa-docker.localhost
ENABLE_SERVICE_WORKER_DEBUGGING=1
UPWARD_JS_UPWARD_PATH=venia-upward.yml
UPWARD_JS_BIND_LOCAL=1
Expand Down
2 changes: 1 addition & 1 deletion docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ This script will:
* run `docker-compose build` to build the container network
* run `docker-compose up` to start the container running PWA at the custom domain with https

After `docker/run-docker` is executed from the root of the repository, the default configuration will have the PWA application running at `https://pwa-docker.local`.
After `docker/run-docker` is executed from the root of the repository, the default configuration will have the PWA application running at `https://pwa-docker.localhost`.

### Configure a new custom domain

Expand Down
2 changes: 1 addition & 1 deletion packages/venia-concept/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"storybook:build": "build-storybook -c .storybook -o storybook-dist",
"validate-queries": "node ./validate-queries.js",
"watch": "webpack-dev-server --progress --color --env.mode development",
"watch:docker": "webpack-dev-server --progress --color --env.mode development --host pwa-docker.local"
"watch:docker": "webpack-dev-server --progress --color --env.mode development --host pwa-docker.localhost"
},
"repository": "github:magento-research/pwa-studio",
"author": "Magento Commerce",
Expand Down
2 changes: 1 addition & 1 deletion pwa-devdocs/_drafts/docker-setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
```
docker/run-docker
```
4. Once the script completes, a locally running instance of pwa will be available at `https://pwa-docker.local`.
4. Once the script completes, a locally running instance of pwa will be available at `https://pwa-docker.localhost`.

The domain is configurable. Two changes are needed to configure a new domain name.

Expand Down

0 comments on commit 3d1bdf0

Please sign in to comment.