Fixed issue causing static test failure to report success on Travis #9872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avis Regression was introduced in e68d69c; can't use a script that does not exit on command failure or exit code is always zero for anything but the last command the script ran. Additionally, moved the test script back into .travis.yml because test failure inside a .sh script will not include sufficient error output.
|
Here is example static build where there were failures, but the test shows green: https://travis-ci.org/magento/magento2/jobs/239757912. This resolves that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues
There was a regression introduced in e68d69c as a result of moving the test script from .travis.yml to the script.sh file. The script was not configured to exit on command failure, which caused the static tests to succeed when
phpunitfails but the subsequentgrunt staticcommand met success.Work Done
I've moved test script back into .travis.yml both to resolve the failure, but also to preserve proper verboseness of tests when they fail. Experimented heavily here when I reworked the entire travis configuration a year or two ago, and it's best for these to be in .travis.yml if possible, so I've moved them back there and made sure all the tests are still run correctly.
The js static tests have also been moved into their own job vs being mashed into the same job running phpunit static tests for the sake of travis test suite simplicity.
Contribution checklist