Allow camelcase in vendorname for menus #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 21, 2015 08:55
- changed regex in menu.xsd
- fix files for unit-tests
|
+1 |
|
👍 |
|
+1 |
|
👍 |
|
+1 |
1 similar comment
|
👍 |
|
Nice idea! |
|
Thank you for this contribution! I've created ticket MAGETWO-33373 internally to process this pull request. |
otoolec
added
Issue: Ready for Work
|
CR: passed |
vpelipenko
added a commit
that referenced
this pull request
Feb 13, 2015
Allow camelcase in vendorname for menus
otoolec
added a commit
that referenced
this pull request
Feb 13, 2015
Modify valid menu xml file test to catch a regression of this fix.
magento-team
added a commit
to abeeskau/magento2-community-edition
that referenced
this pull request
Feb 20, 2015
* Various improvements:
* Existing Builders were replaced with DataFactories in Customer and Tax modules
* Refactored controller actions in the Checkout and CMS modules
* Increased coverage with static tests for `.phtml` files
* Moved Cookie related functionality from `Theme` and `Core` modules into a new `Cookie` module
* Moved minfication configuration settings to the `View` library level
* UI improvements:
* Restyled installation wizard
* Prepared styles for Dashboard in the Backend area
* Framework improvements:
* Added `setCustomAttribute` and `setCustomAttributes` methods to `ExtensibleDataInterface`
* Added setter methods to data object interfaces
* Replaced `Builders` with `Factories`
* Added `DataObjectHelper.php` which contains the common set of methods of all builders
* Refactored `__()` to return `Phrase` object
* Allowed usage of `LocalizedException` on the framework's library level
* Added expiration/lifetime management of frontend resources
* Unified MTF configurations format for Framework, TestCase variations and TestCase scenario configurations
* Fixed bugs:
* Fixed an issue with product reviews list paging
* Fixed an issue where sold products were not displayed in Bestsellers
* Fixed an issue with image rendering on the CMS page on Frontend when `webserver rewrites = no`
* GitHub requests:
* [#790](magento/magento2#790) -- Magento API fails in a CGI env (zf1 issue)
* [#909](magento/magento2#909) -- Manage Titles in popup window front-end issue
* [#996](magento/magento2#996) -- Pager block should support url "fragment".
* [#985](magento/magento2#985) -- Allow camelcase in vendorname for menus
* [#1025](magento/magento2#1025) -- Wrong parameter for getting base url for 'media' path in "Image" form element.
magento-team
pushed a commit
that referenced
this pull request
Dec 11, 2017
…rk size Validation Message. #985
magento-team
pushed a commit
that referenced
this pull request
Dec 11, 2017
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-85311: Added namespace to product videos fotorama events #12469 #991 - MAGETWO-85300: 8437: Silent error when an email template is not found #970 - MAGETWO-85293: 12613: Verbiage Update Required: Product Image Watermark size Validation Message. #985 - MAGETWO-85286: 8176: LinkManagement::getChildren() does not include product visibility. #986 - MAGETWO-85285: 12482: Sitemap image links in MultiStore #935 - MAGETWO-84955: Set Current Store from Store Code if isUseStoreInUrl #12529 - MAGETWO-84764: NewRelic: Disables Module Deployments, Creates new Deploy Marker Command #12477 - MAGETWO-84439: 12180 Remove unnecessary use operator for Context, causes 503 error i… #12220
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you are not able to use camelcase in your vendorname if you create backend-menus.