-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove zend json from form elements #9754
Remove zend json from form elements #9754
Conversation
Maybe hold off on this @davidalger just found something with the wysiwyg editor not sure if it is my change or develop. |
@dmanners Have you had a chance to review what you found with the wysiwyg editor? I can see that you pushed a new commit since your last comment, but on that one the tests are failing. I'm not sure why at first glance. Let me know. Thanks! |
@davidalger I found the issue. It was trying to work with an object and failing but I have had no time to work on the fix as yet. |
@dmanners Any chance you'll be able to circle back to this one some time soon? |
@davidalger been traveling for most of June so far. Guess July I will find some free time for this. 😭 |
Thanks @okorshenko for the extra commit to fix the object issue. You are a star. |
Replace Zend_Json with just a basic json_encode in the configurable product block view test
Description
Since Zend1 is at EOL we should replace any usage of it's elements. For this case we are removing Zend_Json #9236
Fixed Issues (if relevant)
Contribution checklist