Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zend json from form elements #9754

Merged

Conversation

dmanners
Copy link
Contributor

@dmanners dmanners commented May 24, 2017

Replace Zend_Json with just a basic json_encode in the configurable product block view test

Description

Since Zend1 is at EOL we should replace any usage of it's elements. For this case we are removing Zend_Json #9236

Fixed Issues (if relevant)

  1. Upgrade ZF components. Zend_Json #9236: Upgrade ZF components. Zend_Json

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@davidalger davidalger self-assigned this May 24, 2017
@davidalger davidalger added this to the May 2017 milestone May 24, 2017
@davidalger davidalger self-requested a review May 24, 2017 14:53
@dmanners
Copy link
Contributor Author

Maybe hold off on this @davidalger just found something with the wysiwyg editor not sure if it is my change or develop.

@davidalger
Copy link
Member

@dmanners Have you had a chance to review what you found with the wysiwyg editor? I can see that you pushed a new commit since your last comment, but on that one the tests are failing. I'm not sure why at first glance. Let me know. Thanks!

@dmanners
Copy link
Contributor Author

@davidalger I found the issue. It was trying to work with an object and failing but I have had no time to work on the fix as yet.

@okorshenko okorshenko modified the milestones: May 2017, June 2017 Jun 1, 2017
@davidalger
Copy link
Member

@dmanners Any chance you'll be able to circle back to this one some time soon?

@dmanners
Copy link
Contributor Author

@davidalger been traveling for most of June so far. Guess July I will find some free time for this. 😭

@okorshenko okorshenko self-assigned this Jun 28, 2017
@okorshenko okorshenko self-requested a review June 28, 2017 16:51
@magento-team magento-team merged commit abb39b4 into magento:develop Jun 29, 2017
magento-team pushed a commit that referenced this pull request Jun 29, 2017
magento-team pushed a commit that referenced this pull request Jun 29, 2017
@dmanners
Copy link
Contributor Author

Thanks @okorshenko for the extra commit to fix the object issue. You are a star.

@dmanners dmanners deleted the remove-zend-json-from-form-elements branch July 26, 2017 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants