Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed workaround for old Webkit bug in the TinyMCE editor for selec… #9540

Merged
merged 1 commit into from
May 16, 2017
Merged

Removed workaround for old Webkit bug in the TinyMCE editor for selec… #9540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lib/web/tiny_mce/classes/util/Quirks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,8 @@
ed.onClick.add(function(ed, e) {
e = e.target;

// Workaround for bug, http://bugs.webkit.org/show_bug.cgi?id=12250
// WebKit can't even do simple things like selecting an image
// Needs tobe the setBaseAndExtend or it will fail to select floated images
if (/^(IMG|HR)$/.test(e.nodeName))
ed.selection.getSel().setBaseAndExtent(e, 0, e, 1);
ed.selection.select(e);

if (e.nodeName == 'A' && ed.dom.hasClass(e, 'mceItemAnchor'))
ed.selection.select(e);
Expand Down
2 changes: 1 addition & 1 deletion lib/web/tiny_mce/tiny_mce.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/web/tiny_mce/tiny_mce_jquery.js
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 1 addition & 4 deletions lib/web/tiny_mce/tiny_mce_jquery_src.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1441,11 +1441,8 @@ tinymce.create('static tinymce.util.XHR', {
ed.onClick.add(function(ed, e) {
e = e.target;

// Workaround for bug, http://bugs.webkit.org/show_bug.cgi?id=12250
// WebKit can't even do simple things like selecting an image
// Needs tobe the setBaseAndExtend or it will fail to select floated images
if (/^(IMG|HR)$/.test(e.nodeName))
ed.selection.getSel().setBaseAndExtent(e, 0, e, 1);
ed.selection.select(e);

if (e.nodeName == 'A' && ed.dom.hasClass(e, 'mceItemAnchor'))
ed.selection.select(e);
Expand Down
2 changes: 1 addition & 1 deletion lib/web/tiny_mce/tiny_mce_prototype.js
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 1 addition & 4 deletions lib/web/tiny_mce/tiny_mce_prototype_src.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,11 +1193,8 @@ tinymce.create('static tinymce.util.XHR', {
ed.onClick.add(function(ed, e) {
e = e.target;

// Workaround for bug, http://bugs.webkit.org/show_bug.cgi?id=12250
// WebKit can't even do simple things like selecting an image
// Needs tobe the setBaseAndExtend or it will fail to select floated images
if (/^(IMG|HR)$/.test(e.nodeName))
ed.selection.getSel().setBaseAndExtent(e, 0, e, 1);
ed.selection.select(e);

if (e.nodeName == 'A' && ed.dom.hasClass(e, 'mceItemAnchor'))
ed.selection.select(e);
Expand Down
5 changes: 1 addition & 4 deletions lib/web/tiny_mce/tiny_mce_src.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,11 +1166,8 @@ tinymce.create('static tinymce.util.XHR', {
ed.onClick.add(function(ed, e) {
e = e.target;

// Workaround for bug, http://bugs.webkit.org/show_bug.cgi?id=12250
// WebKit can't even do simple things like selecting an image
// Needs tobe the setBaseAndExtend or it will fail to select floated images
if (/^(IMG|HR)$/.test(e.nodeName))
ed.selection.getSel().setBaseAndExtent(e, 0, e, 1);
ed.selection.select(e);

if (e.nodeName == 'A' && ed.dom.hasClass(e, 'mceItemAnchor'))
ed.selection.select(e);
Expand Down