Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Inconsistent Gift Options checkbox labels #9421 #9525

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

vpiyappan
Copy link
Contributor

@vpiyappan vpiyappan commented May 5, 2017

Changed small "gift options" to "Gift Options" for Multisipping
address.

Description

Fixed the Inconsistent Gift Options checkbox labels #9421
Changed the labels "gift options" to "Gift Options" in both CSV file ("app\code\Magento\GiftMessage\i18n\en_US.csv") and phtml file ("app\code\Magento\GiftMessage\view\frontend\templates\inline.phtml")

Fixed Issues (if relevant)

  1. Inconsistent Gift Options checkbox labels #9421: Inconsistent Gift Options checkbox labels
    gift_options

  2. ...

Manual testing scenarios

  1. Add product to cart with gift options enabled.
  2. Add Gift message in cart page.
  3. Click "Multishipping Checkout" from cart page.
  4. You can find all the Labels listed along with checkbox "Gift Options" all are consistent

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Changed small "gift options"  to "Gift Options" for Multisipping
address.
@ishakhsuvarov
Copy link
Contributor

@vpiyappan
Hi, please accept the CLA so that we can proceed with the merge of your PR.
You should have an email address used in the commit linked to your github account to do that
Thanks.

@miguelbalparda miguelbalparda self-assigned this May 13, 2017
@miguelbalparda miguelbalparda added this to the May 2017 milestone May 13, 2017
@miguelbalparda
Copy link
Contributor

@vpiyappan were you able to review and sign the CLA? This is ready to be merged once it is signed.

@okorshenko okorshenko modified the milestones: May 2017, June 2017 Jun 1, 2017
@okorshenko okorshenko self-assigned this Jun 13, 2017
@magento-team magento-team merged commit f68dd92 into magento:develop Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants