Fixed indexed product positions for anchor categories.

[obuchowski]

Description

Indexed product positions saved in catalog_category_product_index table are incorrect for those products which could be found in child categories.

Manual testing scenarios

Initial data:
Category 2 (category with id == 2) is anchor.
Category 37 (category with id == 37) is category's 2 child

1.1. Append product to a category 2. Set its position to 2.
1.2. Run php bin/magento indexer:reindex catalog_product_category
1.3. The result is CORRECT (both catalog_category_product and catalog_category_product_index tables shows a product position == 2)

1.4. Remove a product from a category 2

2.1. Append a product to a category 37. Set its position to 3.
2.2. Run php bin/magento indexer:reindex catalog_product_category
2.3. The result is CORRECT (position == 3 for a category 37 and 10000 + 3 for an anchor category 2)

3.1. Repeat a step#1.1 ( Append product to a category 2. Set its position to 2.)
3.2. Run php bin/magento indexer:reindex catalog_product_category
3.3. The result is INCORRECT (position for a product in a category 2 in the table catalog_category_product_index should be 2. But it is 10000 + 3 like in the second scenario)

Fixed Issues

Position for a product assigned to anchor categories is indexed currectly whether or not it has entries in child categories.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[akaplya]

Hi @EObukhovsky Thank you for your contribution!
Can you provide more input about the issue. The way how product was assigned (UI/API)? Selected indexer mode?

[obuchowski]

Hi @akaplya ,
I personally tested it on products from a sample data.
Indexer mode was "update on save".
But I believe it doesn't matter since this part of indexer doesn't depend on such things, it just operates with database entities.
If a product is assigned to an anchor category and this product is also assigned to this anchor category's child then position from the anchor is ignored.
For example magento1 processes this situation correctly.
https://github.com/OpenMage/magento-mirror/blob/magento-1.9/app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php#L537

[okorshenko]

@akaplya any progress on this?

[Ctucker9233]

@magento-team can this be backported to 2.2?