Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed coding standard violations in the Framework\Archive namespace #9250

Merged
merged 2 commits into from
Apr 19, 2017
Merged

Fixed coding standard violations in the Framework\Archive namespace #9250

merged 2 commits into from
Apr 19, 2017

Conversation

dverkade
Copy link
Member

@dverkade dverkade commented Apr 14, 2017

Fixed coding standard violations in the Framework\Archive namespace, so that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes:

  • Removed @codingStandardsIgnoreFile from the file still containing this at the head of the file
  • Fixed indentation
  • Fixed number of chars per line
  • Removed unused "use" namespace at the top of the file.

- Removed @codingStandardsIgnoreFile
- Fixed indentation
- Fixed number of chars per line
- Removed unused "use" namespace at the top of the file.
@vrann vrann self-assigned this Apr 14, 2017
@vrann vrann added this to the April 2017 milestone Apr 14, 2017
@magento-team magento-team merged commit 343f306 into magento:develop Apr 19, 2017
magento-team pushed a commit that referenced this pull request Apr 19, 2017
@magento-team
Copy link
Contributor

@dverkade thank you for your contribution to Magento 2 project

@dverkade dverkade deleted the Fix_coding_standard_in_Framework-Archive branch June 22, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants