Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid: Undefined index: value in app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Validate.php on line 157 in Ajax return #9221

Merged
merged 2 commits into from
Apr 13, 2017

Conversation

mhauri
Copy link

@mhauri mhauri commented Apr 12, 2017

When saving an Attribute and the array $options doesn't contain a key named 'value' or 'delete' it will return a Notice Warning instead of the expected ajax result in admin/catalog/product_attribute/validate/attribute_id/XXX/

Description

This PR will check if the keys 'value' and 'delete' are set.

Fixed Issues (if relevant)

  1. Cannot save attribute #8202: Cannot save attribute
  2. Visibility save attribute error #8271: Visibility save attribute error

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 12, 2017

CLA assistant check
All committers have signed the CLA.

@adragus-inviqa
Copy link
Contributor

Hi. Appreciate the time, but there's a small suggestion I'd like to make. The style should be:

if (foo &&
    bar &&
    baz) {
//  ...
}

For the life of me I can't find the style guide (I was looking in PSR-2), but I'm sure I can find it somewhere. 😬

@vrann vrann self-assigned this Apr 12, 2017
@vrann vrann added this to the April 2017 milestone Apr 12, 2017
@magento-team magento-team merged commit 439113f into magento:develop Apr 13, 2017
magento-team pushed a commit that referenced this pull request Apr 13, 2017
…log/Controller/Adminhtml/Product/Attribute/Validate.php on line 157 in Ajax return #9221
@magento-team
Copy link
Contributor

@mhauri Thank you for the contribution

magento-devops-reposync-svc pushed a commit that referenced this pull request Sep 12, 2024
[Support Tier-4 chittima] 08-29-2024 Regular delivery of bugfixes and improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants