Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Google Analytics typo in printing Account Number, fixes #7549 #9084

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Fix Google Analytics typo in printing Account Number, fixes #7549 #9084

merged 1 commit into from
Apr 13, 2017

Conversation

sambolek
Copy link
Contributor

@sambolek sambolek commented Mar 31, 2017

Once Account Number is entered in Google Analytics part of Magento admin, there's a bug in printing it out on frontend - apostrophe sign that wraps the GTM ID is missing.

Description

Apostrophe is added during GTM print, which fixes this issue.

Fixed Issues (if relevant)

  1. Google API Tracking code missing single quote after account number #7549

Manual testing scenarios

  1. Enable Google Analytics and set Account Number in Magento Analytics module via administration http://prntscr.com/eqwf6m
  2. Observe that GTM ID is missing apostrophe sign after it, which wraps the value http://prntscr.com/eqwfrl

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@PieterCappelle
Copy link
Contributor

Is this PR only in 2.2 or also in 2.1 and 2.0?

@sambolek
Copy link
Contributor Author

sambolek commented Apr 1, 2017

This seems to be broken only in develop branch, typo got introduced with this commit ed86a75 , so 2.1 and 2.0 should work okay.

The fix is only for develop branch.

@PieterCappelle
Copy link
Contributor

Thanks for feedback @sambolek! Oef :-)

@vrann vrann self-assigned this Apr 1, 2017
@vrann vrann added this to the April 2017 milestone Apr 1, 2017
@vrann vrann added the bugfix label Apr 1, 2017
@magento-team magento-team merged commit 142b6f4 into magento:develop Apr 13, 2017
@magento-team
Copy link
Contributor

@sambolek thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants