Correctly process global product attributes #5941

[therool]

Description

Correctly process global product attributes when generating sitemap and added public method to process select statement before executing it so it can be modified with plugins. This is an fix for #5941

Fixed Issues (if relevant)

1. If name attribute scope is changed to global, sitemap crashes #5941: If name attribute scope is changed to global, sitemap crashes

Manual testing scenarios

1. Change store to single store view mode
2. Make "name", "thumbnail", "image" product attributes global
3. Go to "Marketing -> Site Map"
4. Press "Add Site Map"
5. Enter "sitemap.xml" as "Filename" and "/pub/" as "Path"
6. Press "Save & Generate"

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[okorshenko]

Hi @therool
Could you please fix broken tests so that we can proceed with Pull Request acceptance?
Thank you

[therool]

Hello, as I understhand then this is this the test which failed:

Time: 2.8 minutes, Memory: 220.25MB
There was 1 failure:
1) Magento\Test\Php\LiveCodeTest::testCodeStyle
PHP Code Sniffer detected 1 violation(s): 
FILE: ...gento2/app/code/Magento/Sitemap/Model/ResourceModel/Catalog/Product.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 439 | ERROR | Missing function doc comment
--------------------------------------------------------------------------------
Failed asserting that 1 matches expected 0.
/home/travis/build/magento/magento2/dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php:210
                                                 
FAILURES!                                        
Tests: 3, Assertions: 2, Failures: 1, Skipped: 1.

That line contains a function from other than my commit https://github.com/therool/magento2/blob/faa7cd1fb0a217fd128867ce6fac6ec7d477b831/app/code/Magento/Sitemap/Model/ResourceModel/Catalog/Product.php#L439 and that seems to be issue not related to my provided changes.

I found that the issue is really on the line 433 and is due the function docblock being incorrectly defined - it is:

    /*
     * Get product image URL from image filename and path
     *
     * @param string $image
     * @return string
     */

but needs to be:

   /**
     * Get product image URL from image filename and path
     *
     * @param string $image
     * @return string
     */

It is missing additional * after the /*, do I need to push this docblock fix?

[okorshenko]

Hi @therool that would great if you can fix this issue so that we can make sure that your changes do not fail the builds. Thank you