Fix product option files not copying to order dir. #8462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy product option file to order directory from quote also when media storage is set to file system, not just database. Also rename _rootDirectory variable to _mediaDirectory, since that's what it is.
okorshenko
suggested changes
Feb 26, 2017
| @@ -492,7 +489,15 @@ public function copyQuoteToOrder() | |||
| * @param string $url | |||
| * @return $this | |||
| */ | |||
| public function setCustomOptionDownloadUrl($url) | |||
| public function setCustomOp | |||
There was a problem hiding this comment.
this code looks broken. @evktalo could you please review this code and fix it, so that i can proceed with acceptance of this PR. Thank you
This reverts commit 3a2a057. This was a very broken commit.
… still test mediaDirectory->copyFile().
|
Hi @evktalo could you please fix unit tests so that we can process this PR? |
|
Yes, I will work on fixing the tests. Thank you! |
|
@evktalo I will the the tests on our side and will proceed with PR acceptance. Thank you! |
okorshenko
added
Component: Sales
Progress: accept
and removed
Progress: needs update
labels
|
@evktalo thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy product option file to order directory from quote also when media storage is set to file system, not just database.
Also rename _rootDirectory variable to _mediaDirectory, since that's what it is.