Fixes #7723 - saving multi select field in UI component form #8246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetlen
reviewed
Feb 2, 2017
| @@ -54,6 +54,11 @@ define([ | |||
| } | |||
| break; | |||
|
|
|||
| case 'select-multiple': | |||
| var name = item.name.substring(0,(item.name.length - 2)); //remove [] from the name ending | |||
| result[name] = Array.prototype.slice.call(item.selectedOptions).map(function(o) {return o.value;}); | |||
There was a problem hiding this comment.
Since you are not mutating item.selectedOptions in place, there should be no need to clone it with Array.prototype.slice. Also, It might be clearer to use Underscore here, because this pattern is very common:
result[name] = _.pluck(item.selectedOptions, 'value');
|
@vrann Thanks for the hint. I changed the code and double checked on my end. |
|
@Zefiryn Thank you for your contribution to Magento 2 project! Your pull request has been successfully merged! |
|
@okorshenko @Zefiryn does this also fix #8215 when using the condition "SKU is" used and adding mulitple sku's in the UI only results in the first 2 sku's being affected? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix resolves issue #7723 and allows to send all selected values of multi-select field in form handled by UI compontent