Add simple bugfix for View\Page\Config\Reader\Html with test #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vinai
commented
Nov 19, 2014
Vinai
commented
- Add integration test for View\Page\Config\Reader\Html since mocking SimpleXmlElement isn't possible
- Add simple bugfix for View\Page\Config\Reader\Html
|
The failed integration test dev/tests/integration/testsuite/Magento/Directory/Model/ObserverTest.php:93 seems in no way related to my change in the commit as far as I can see.
|
|
Thank you for your contribution, @Vinai! The team will review it. We will get back to you once we have the result. |
|
Hi @Vinai, the bug fix was implemented. Please update the PR, if you interested into contribution test to mainline. Thanks |
okorshenko
pushed a commit
that referenced
this pull request
Feb 7, 2017
MAGETWO-63168: Incorrect configuration tests on Travis CI
VitaliyBoyko
pushed a commit
to VitaliyBoyko/magento2
that referenced
this pull request
Mar 24, 2018
…t-qty Fix add to cart using itemQty instead of requestedQty
magento-engcom-team
added a commit
that referenced
this pull request
Jun 21, 2019
- Merge Pull Request magento/graphql-ce#749 from magento/graphql-ce:687-Redundant-isset - Merged commits: 1. aeec8f7
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 21, 2019
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.