-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove breadcrumbs for multistore homepage #6503
Conversation
When there are multiple different cms home pages with same identifier but for different store views, breadcrumbs are shown in all of them except the first. The same applies for 404 pages.
@PingusPepan Hi, Ill appritiate if you explain to me how spliting string by | delimiter, helps to find home page identifier. I Suppose you have some sequence such as "home_page_id|something_else". However by default Magento dont have this functionality |
@sereban I copied this exact code from Magento 2 core code and just altered it for homepage and 404 recognition. I think the |
You can see where and why this happens in file If there are two same identifiers, it adds the delimiter. That's fine, it just wasn't accounted for in the breadcrumbs homepage and 404 check code. I only added the check for it and now it works just fine. #6504 is fixed by this PR. The delimiter lives only in config so it can't be seen while editing the page or in cms database table. |
@PingusPepan Ok So if there is identifier and page title for home page than they save with delimiter. Cool. Thanks. We will see PR. |
Has anyone looked into this? It's a simple bug fix and it would help to have it fixed in Magento. This way I have to manually replace the file after every test install/update |
@PingusPepan Thank you for the contribution |
When there are multiple different cms home pages with same identifier but for different store views, breadcrumbs are shown in all of them except the first.
The same applies for 404 pages.
Fixes #6504