Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace EE License Placeholder text with filename #6385

Merged
merged 2 commits into from
Apr 13, 2017
Merged

Replace EE License Placeholder text with filename #6385

merged 2 commits into from
Apr 13, 2017

Conversation

navarr
Copy link
Member

@navarr navarr commented Aug 29, 2016 •
edited by vrann
Loading

Resolves #5528

orlangur
orlangur requested changes Oct 13, 2016
View reviewed changes
COPYING.txt Outdated
Please see LICENSE_EE.txt for the full text of the MEE License or visit http://magento.com/legal/terms/enterprise.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think referring to a file which is actually missing in CE repository is correct.

Is there any problem with adding this file to CE repository also? It does not seem to me to bring any confusion as each module defines applicable licenses.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am personally uncomfortable adding the LICENSE which as of now is only available in software that is supposed to be kept private to the repository.

I would not want to open myself nor my employer up to any sort of legal issue related to revealing things we shouldn't.

@vrann vrann self-assigned this Mar 21, 2017
@vrann vrann added this to the March 2017 milestone Mar 21, 2017
@orlangur
Copy link
Contributor

@vrann do you mean some response in internal discussion? Here we finished our conversation with PR author as he is really not in charge of adding new license file to repo :)

@vrann
Copy link
Contributor

vrann commented Mar 23, 2017

@orlangur exactly.

@okorshenko okorshenko modified the milestones: March 2017, April 2017 Apr 2, 2017
@vrann
Copy link
Contributor

vrann commented Apr 12, 2017

@navarr can you please merge with the latest develop? I'm ready to accept it

@magento-team magento-team merged commit 5c136a8 into magento:develop Apr 13, 2017
magento-team pushed a commit that referenced this pull request Apr 13, 2017
MAGETWO-67433: Replace EE License Placeholder text with filename #6385
7cb6d45
@magento-team
Copy link
Contributor

@navarr thank you for your contribution to Magento 2 project

@navarr navarr deleted the patch-5 branch April 13, 2017 12:32
magento-engcom-team pushed a commit that referenced this pull request Dec 13, 2020
@dhorytskyi
Merge pull request #6385 from magento-l3/BUGFIX-11-23
ad29452 
[tango] BUGFIX DELIVERY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur requested changes

Assignees

@vrann vrann

Labels
None yet
Projects
None yet
Milestone
April 2017
Development

Successfully merging this pull request may close these issues.
6 participants
@navarr @orlangur @vrann @magento-team @vkublytskyi @okorshenko