Add missing return in resolveShippingRates #6321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the function resolveShippingRates is a missing
return
statement afterselectShippingMethodAction
. Without this statement it can happen, thatselectShippingMethodAction
is called second time.This leads to the point thatselectShippingMethodAction
is called with the parametertrue
and that for example shipping.js returnsundefined - undefined
as carrier title and method title of the shipping method.This behavior can be reproduced with
1
cart-totals
will be rendered twiceand the second time withShipping (undefined - undefined)
Edit
Since commit e72482c9fd7eeaac29f9710b6c39c9eafe5ed0b0 the code
has changed to
and the
undefined - undefined
problem doesn't occur anymore, but without thereturn
statement the functionselectShippingMethodAction
is called twice with the same argument and the shipping method is rendered twice without any reason.