Update AbstractTemplate.php

[vivek201]

Added strict comparison for $storeID

Regarding issues #5288, #5666 and #5703.

Issue:
Global Design Configuration does not save.

Scenario:
When the design configuration for the Global Scope is saved, the configuration tries to validate the transactional email header and footer templates through https://github.com/magento/magento2/blob/2.1/app/code/Magento/Theme/Model/Design/Config/Validator.php#L69.
For email templates, the $template is an object of Magento\Email\Model\Template which is inherited from Magento\Email\Model\AbstractTemplate . And in line 670 is the emulateDesign function.
When the design is saved from the global scope, the $storeId being passed is 0, so false is returned even when an actual value is being passed.

Solution:
Change the if condition to if ($storeId !== false).

[quienti]

Duplicate #5729

[vivek201]

Yeah, the pull request was made to 2.1 branch and I just read that only pull requests to dev branch will be accepted

[vkorotun]

Internal ticket: MAGETWO-58368

[Ctucker9233]

@vkorotun @mmansoorebay Will MAGETWO-58368 be included in 2.1.3?

[paddz]

It isn't included in 2.1.3, still got the same error.

[Ctucker9233]

Still not in 2.1.10. Can someone @magento-engcom-team please look at this?

[ishakhsuvarov]

Hi @vivek201
We have just noticed that Contributor License Agreement was not signed for this Pull Request.

Could you please follow the CLA Assistant link and sign it?

Thank you for collaboration.

[vivek201]

Hi @ishakhsuvarov, it's done

[ishakhsuvarov]

@vivek201 Thank you for collaboration!

[Blatant]

@ishakhsuvarov & @magento-engcom-team, this issue is marked as fixed in Magento 2.1.x however I just checked out the latest 2.1 branch and it appears to be the old version?

https://github.com/magento/magento2/blob/2.1/app/code/Magento/Email/Model/AbstractTemplate.php

Is that right or have aI lost my marbles??