Change pub/.htaccess MAGE_MODE comment #5367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI - I've signed the CLA a couple of times for this specific PR, but it's still showing as "not signed". |
|
With nginx, there's no problem with such syntax (in-line comments). |
|
@erikhansen thank you for your contribution |
|
@magento-team @vrann Thanks for merging this PR. I just created another PR to fix an indentation issue created by this PR: #9234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Magento 2.1, the
pub/.htaccessfile was changes to include a comment demonstrating how a developer could change theMAGE_MODEto any of the three modes:This change was great, however simply uncommenting the line in the .htaccess file resulted in this line:
The line above results in an Apache Internal Server 500 error, as it is invalid. My pull request moves the comment above the commented-out command so that developers don't accidentally cause an error.