Fix undefined offset notice when no order states are set #4903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the DB has no order states (or just missing non-visible, or visible ones), M2 throws with `Notice: Undefined offset: 1 in /vagrant/vendor/magento/module-sales/Model/Order/Config.php on line 256`. You can argue that M2 shouldn't take into consideration invalid DBs, and I would just slightly agree with you, but, for such a small fix, why bother arguing that in the first place, eh?
|
Hello @adragus-inviqa, Thank you for contribution and sorry for the response delay. |
|
What's the status on this? |
|
@adragus-inviqa thank you for your contribution to Magento 2 project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the DB has no order states (or just missing non-visible, or visible ones), M2 throws with
Notice: Undefined offset: 1/0 in /vagrant/vendor/magento/module-sales/Model/Order/Config.php on line 256.You can argue that M2 shouldn't take into consideration invalid DBs, and I would just slightly agree with you there, but, for such a small fix, why bother arguing that in the first place, eh? I've also added an un-related strict checking.