Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get.php #4224

Merged
merged 1 commit into from
Mar 25, 2017
Merged

Update get.php #4224

merged 1 commit into from
Mar 25, 2017

Conversation

thaiphan
Copy link
Contributor

@thaiphan thaiphan commented Apr 19, 2016

This change will stop Magento from unnecessarily looping through all the remaining allowed resources if it discovers that the resource in question is already allowed.

@@ -22,6 +22,7 @@
foreach ($allowedResources as $allowedResource) {
if (0 === stripos($resource, $allowedResource)) {
$isResourceAllowed = true;
break;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thaiphan, thank you for code improvement.

As this is function body there is no need in $isResourceAllowed variable. @thaiphan, would you refactor code with simple return true inside condition statement and return false at the end of function, please?

@vkublytskyi vkublytskyi added the PS label Apr 19, 2016
@thaiphan
Copy link
Contributor Author

Hey @vkublytskyi, I've done as you've asked.

@vkublytskyi
Copy link

@thaiphan, thank you for quick response. We will process this PR

@vkublytskyi
Copy link

Internal ticket MAGETWO-52019

@okorshenko okorshenko added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 5, 2016
@thaiphan
Copy link
Contributor Author

@piotrekkaminski, @okobchenko, @vkublytskyi, @joanhe, what's the status of this pull request?

@vkorotun vkorotun added Application Framework bugfix and removed PS Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Aug 3, 2016
@sshrewz sshrewz added the linked label Aug 11, 2016
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
@piotrekkaminski piotrekkaminski removed their assignment Aug 22, 2016
@thaiphan thaiphan closed this Jan 21, 2017
@vrann vrann self-assigned this Mar 24, 2017
@vrann vrann added this to the March 2017 milestone Mar 24, 2017
@magento-team magento-team merged commit f6d7cf5 into magento:develop Mar 25, 2017
magento-team pushed a commit that referenced this pull request Mar 25, 2017
@vrann
Copy link
Contributor

vrann commented Mar 25, 2017

@thaiphan Merged! Thank you for the contribution.

@thaiphan
Copy link
Contributor Author

Yay!

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 21, 2019
[pangolin] MQE-1566: Fix mftf and zephyr tests that results in non unique match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants