Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added call to action to compile command error #4134

Merged
merged 3 commits into from
Nov 11, 2016
Merged

Added call to action to compile command error #4134

merged 3 commits into from
Nov 11, 2016

Conversation

sammarcus
Copy link
Contributor

The original informational message stated the situation but did not suggest how to resolve it. By suggesting how to rectify the situation, it is far more useful than sending the user on a goose chase.

@sammarcus
Added call to action to compile command error
7f864dd 
The original informational message stated the situation but did not suggest how to resolve it. By suggesting how to rectify the situation, it is far more useful than sending the user on a goose chase.
@sammarcus
Copy link
Contributor Author

An example is #2457 seems to have confusion over how to fix this, so a more informational message would be helpful.

@sammarcus sammarcus mentioned this pull request Apr 13, 2016
Closed
@mazhalai
Copy link
Contributor

mazhalai commented May 6, 2016 •
edited
Loading

@sammarcus please sync with the develop branch and rerun travis builds. Also, there are static test failures. https://travis-ci.org/magento/magento2/jobs/122719584#L618

@vzaporozhets vzaporozhets removed the PS label Aug 3, 2016
@sshrewz
Copy link

sshrewz commented Aug 11, 2016

Internal ticket - MAGETWO-56787

@sshrewz sshrewz added the linked label Aug 11, 2016
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
@caneraydinbey
Copy link

caneraydinbey commented Sep 6, 2016 •
edited
Loading

caner@vegan:/var/www/html/magento/bin$ sudo magento setup:di:compile
sudo: magento: command not found
caner@vegan:/var/www/html/magento/bin$ sudo su
root@vegan:/var/www/html/magento/bin# magento setup:di:compile
magento: command not found
root@vegan:/var/www/html/magento/bin# exit
exit
caner@vegan:/var/www/html/magento/bin$ magento setup:di:compile
The file "/var/www/html/magento/var/generation/Composer/Console/ApplicationFactory.php" cannot be deleted Warning!unlink(/var/www/html/magento/var/generation/Composer/Console/ApplicationFactory.php): Permission denied#0 /var/www/html/magento/vendor/magento/framework/Filesystem/Driver/File.php(405): Magento\Framework\Filesystem\Driver\File->deleteFile('/var/www/html/m...')
#1 /var/www/html/magento/vendor/magento/framework/Filesystem/Driver/File.php(403): Magento\Framework\Filesystem\Driver\File->deleteDirectory('/var/www/html/m...')
#2 /var/www/html/magento/vendor/magento/framework/Filesystem/Driver/File.php(403): Magento\Framework\Filesystem\Driver\File->deleteDirectory('/var/www/html/m...')
#3 /var/www/html/magento/setup/src/Magento/Setup/Console/CompilerPreparation.php(68): Magento\Framework\Filesystem\Driver\File->deleteDirectory('/var/www/html/m...')
#4 /var/www/html/magento/vendor/magento/framework/Console/Cli.php(74): Magento\Setup\Console\CompilerPreparation->handleCompilerEnvironment()
#5 /var/www/html/magento/bin/magento(22): Magento\Framework\Console\Cli->__construct('Magento CLI')
#6 {main}

PHP Fatal error: Class 'Cli' not found in /var/www/html/magento/bin/magento on line 31
PHP Stack trace:
PHP 1. {main}() /var/www/html/magento/bin/magento:0
caner@vegan:/var/www/html/magento/bin$

@sammarcus
Copy link
Contributor Author

@caneraydinbey what is your last comment? It looks like you're not in the right directory and have some permissions issues, but neither of those are related to this PR.

@sammarcus sammarcus closed this Oct 18, 2016
@sammarcus sammarcus reopened this Oct 18, 2016
@sammarcus
Copy link
Contributor Author

@mazhalai all set and my build now passes, can this PR please be considered for merging now?

@caneraydinbey
Copy link

I think i changed php to 7 and solved.

@sammarcus
Copy link
Contributor Author

@caneraydinbey your problem has nothing to do with what this PR addresses. please open your own issue if you feel it warrants it.

@Ctucker9233
Copy link

Please merge

@sammarcus
Copy link
Contributor Author

@Snohe @mazhalai can this be merged?

@BaDos BaDos mentioned this pull request Nov 9, 2016
Closed
@mmansoor-magento mmansoor-magento merged commit f21db1a into magento:develop Nov 11, 2016
mmansoor-magento pushed a commit that referenced this pull request Nov 11, 2016
MAGETWO-56787: [GITHUB][PR] Added call to action to compile command e…
c77d9d9 
…rror #4134
mmansoor-magento pushed a commit that referenced this pull request Nov 11, 2016
MAGETWO-56787: [GITHUB][PR] Added call to action to compile command e…
f93b475 
…rror #4134
mmansoor-magento pushed a commit that referenced this pull request Nov 11, 2016
MAGETWO-56787: [GITHUB][PR] Added call to action to compile command e…
35ae13d 
…rror #4134
mmansoor-magento pushed a commit that referenced this pull request Nov 11, 2016
@MomotenkoNatalia
Merge pull request #583 from magento-falcons/MAGETWO-60647
d403ec9 
Fixed issues:
- MAGETWO-60647: Delivery of bug fixes for Sample Data and Import/Export
- MAGETWO-56787: [GITHUB][PR] Added call to action to compile command error #4134
- MAGETWO-56786: [GITHUB][PR] Ensure composer.json exists #4121
- MAGETWO-57799: cannot upgrade 2.0 => 2.1 with auto_increment > 1
- MAGETWO-59715: Impossible to import additional_images with labels which have a comma separator
- MAGETWO-60633: [Github] .htaccess deny code execution not working for Apache + php-fpm #6766
- MAGETWO-46636: Nginx doesn't redirect to setup page when using port
@BaDos
Copy link
Contributor

BaDos commented Nov 11, 2016

Merged.
Thank you for your contribution.

@Ctucker9233
Copy link

Still not included in 2.1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BaDos BaDos

Labels
Component: Setup improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.