Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page-cache.js #4102

Closed
wants to merge 2 commits into from
Closed

Update page-cache.js #4102

wants to merge 2 commits into from

Conversation

viktor-zhuromskyy
Copy link

Fix Bug: page-cache.js:40 «Uncaught TypeError: element.prop is not a function»
Reference: https://mage2.pro/t/topic/999

Fix Bug: page-cache.js:40 «Uncaught TypeError: element.prop is not a function»
Reference: https://mage2.pro/t/topic/999
@daim2k5
Copy link
Contributor

daim2k5 commented Apr 16, 2016

@devdesco-ceo Thank you for your contribution. Please accept the contributors license agreement so this PR can be further processed. This can be done by clicking the "Details" link next to the "license/cla" check below.

Properly wrap virtual product items into a block.
@mazhalai
Copy link
Contributor

@devdesco-ceo can you please resync with develop and restart builds?

@mazhalai mazhalai self-assigned this Apr 20, 2016
@viktor-zhuromskyy
Copy link
Author

Can't figue out how to resync with base

@adragus-inviqa
Copy link
Contributor

/cc #4022

@piotrekkaminski
Copy link
Contributor

@devdesco-ceo https://help.github.com/articles/syncing-a-fork/ ?

@irenelagno
Copy link
Contributor

hi! @devdesco-ceo,
thank you for contribution. Please fix failing builds.
Internal ticket MAGETWO-56693 was created to process your PR.

@sshrewz sshrewz added the linked label Aug 11, 2016
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
@aakimov
Copy link
Contributor

aakimov commented Aug 30, 2016

Hi @devdesco-ceo,

This pull request will be closed as duplicate of #4022.

Thank you for your understanding and interest in Magento.

@aakimov aakimov closed this Aug 30, 2016
@Apurva025
Copy link

@devdesco-ceo, @daim2k5 ,
Hello All,

After applying fix as .prop('href', element.src)

New JS error is appearing:
Error: Permission denied to access property "document"
elem.contentDocument || elem.contentWindow.document : jquery.js (line 2998, col 1)

image

@adragus-inviqa
Copy link
Contributor

@Apurva025 - #4496 (comment)

@Apurva025
Copy link

@adragus-inviqa,

This isn't working.
(function lookup(element) {
if ($.nodeName(element, "iframe") && $(element).prop('src').indexOf(window.location.hostname) != -1) { return; }
Its giving same error:
Error: Permission denied to access property "document"
elem.contentDocument || elem.contentWindow.document : jquery.js (line 2998, col 1)

Now if I change above code as:
if ($.nodeName(element, "iframe") ) { return; }

that is removing && $(element).prop('src').indexOf(window.location.hostname) != -1
This is working for me.

Can, I remove this condition "&& $(element).prop('src').indexOf(window.location.hostname) != -1" ?
Is there any other way of checking above condition
"&& $(element).attr('src').indexOf(window.location.hostname) != -1" is also giving error.

@Apurva025
Copy link

@adragus-inviqa,

These both are working

  1. **($.nodeName(element, "iframe") ) { return; }**
    
    Or
  2. **if ($.nodeName(element, "iframe")  && $('iframe').prop('src').indexOf(window.location.hostname) != -1) { return; }** 
    

ishakhsuvarov referenced this pull request in magento/inventory May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Component: Framework/Cache Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: reject
Projects
None yet
Development

Successfully merging this pull request may close these issues.