-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update page-cache.js #4102
Update page-cache.js #4102
Conversation
Fix Bug: page-cache.js:40 «Uncaught TypeError: element.prop is not a function» Reference: https://mage2.pro/t/topic/999
@devdesco-ceo Thank you for your contribution. Please accept the contributors license agreement so this PR can be further processed. This can be done by clicking the "Details" link next to the "license/cla" check below. |
Properly wrap virtual product items into a block.
@devdesco-ceo can you please resync with develop and restart builds? |
Can't figue out how to resync with base |
/cc #4022 |
@devdesco-ceo https://help.github.com/articles/syncing-a-fork/ ? |
hi! @devdesco-ceo, |
Hi @devdesco-ceo, This pull request will be closed as duplicate of #4022. Thank you for your understanding and interest in Magento. |
@devdesco-ceo, @daim2k5 , After applying fix as .prop('href', element.src) New JS error is appearing: |
This isn't working. Now if I change above code as: that is removing && $(element).prop('src').indexOf(window.location.hostname) != -1 Can, I remove this condition "&& $(element).prop('src').indexOf(window.location.hostname) != -1" ? |
These both are working
|
Fix Bug: page-cache.js:40 «Uncaught TypeError: element.prop is not a function»
Reference: https://mage2.pro/t/topic/999