Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed post var name for update attributes #4011

Merged
merged 1 commit into from
Aug 22, 2016
Merged

Fixed post var name for update attributes #4011

merged 1 commit into from
Aug 22, 2016

Conversation

Corefix
Copy link
Contributor

@Corefix Corefix commented Apr 5, 2016

Fixed request variable name for checking if attribute have been changed, so it matches template definition of this. Otherwise saving multiselect fields doesn't work when using update attributes from the dropdown in the default Product > Catalog Grid.

@Corefix
Fixed post var name for update attributes
99ce202 
Fixed request variable name for checking if attribute have been changed, so it matches template definition of this. Otherwise saving multiselect fields doesn't work when using update attributes from the dropdown in the default Product > Catalog Grid.
@piotrekkaminski
Copy link
Contributor

internal issue MAGETWO-53808

@hshar7
Copy link
Contributor

hshar7 commented Jul 26, 2016

Seems like there are many failures, @Corefix
Could you please take a look at Travis build.

@Corefix
Copy link
Contributor Author

Corefix commented Jul 27, 2016

@hshar7 This is a rather old PR, if I remember right every build here was failing, I'm changing a var name because it is simply wrong. Looking at travis it seems more like their was an error in file permisions somewhere. However this is still an issue in Magento 2.1.

@hshar7
Copy link
Contributor

hshar7 commented Jul 28, 2016

@Corefix okay, I will run our internal builds on this with latest develop merged

@vkorotun vkorotun removed the MX label Aug 3, 2016
@sshrewz sshrewz added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Component: Catalog labels Aug 3, 2016
@vkorotun vkorotun added bugfix and removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Aug 5, 2016
@sshrewz sshrewz added the linked label Aug 11, 2016
@hshar7
Copy link
Contributor

hshar7 commented Aug 16, 2016

Hey @Corefix I see that there is no mention of 'toggle_' inside templates for Catalog module. I do see however many occurrences of '_checkbox' which you are trying to remove. Can you please explain?

@Corefix
Copy link
Contributor Author

Corefix commented Aug 17, 2016

HI @hshar7
Its not in the template but in a the block: app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Attributes.php

@hshar7
Copy link
Contributor

hshar7 commented Aug 18, 2016

@Corefix can you please provide steps on how to reproduce this? Seems like something is actually wrong there but we need to verify the bug before accepting the pr. Thank you.

@Corefix
Copy link
Contributor Author

Corefix commented Aug 18, 2016

Hi @hshar7 Yes ofc:

  1. Go to admin: Product > Catalog ... I'm still not sure why its not the other way around if you can explain that to me too ;-) (meaning that the main menu item is called Catalog and secound is called Product.. where you actually edit products :-))
  2. Select one or more products
  3. From Actions dropdown choose "Update attributes"
  4. Edit a multi select attribute. The checkbox you need to check here to edit is the one I'm refereing to.
  5. Press Save.

It says OK, but the product(s) have not been updated. Tested on Magento 2.1 CE

@hshar7
Copy link
Contributor

hshar7 commented Aug 18, 2016

@Corefix nice! It fixes it!
as for your questions, I am but a simple engineer :) that question is for the guys at UI design. Please let me know the answer when you find out :D

@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
@mmansoor-magento mmansoor-magento merged commit 99ce202 into magento:develop Aug 22, 2016
mmansoor-magento pushed a commit that referenced this pull request Aug 22, 2016
@sdwright
Merge pull request #273 from magento-jackalopes/jack-kanban2-pr
8904497 
Fixes for:
    MAGETWO-56868 Cannot save a product with images for the second time
    MAGETWO-54355 [Github][PR] Bugfix: Unable to activate search form on phone #3770
    MAGETWO-54580 [Github][PR] added partial fix for issue #2617. #3688
    MAGETWO-53808 [Github][PR] Fixed post var name for update attributes #4011
    MAGETWO-55950 Automate Create new Email Template test
    MAGETWO-56197 Write functional test for Account sharing settings availability
magento-engcom-team pushed a commit that referenced this pull request Apr 9, 2019
@xmav
Merge pull request #4011 from magento-tsg/2.2-develop-pr88
33f35ce 
[TSG] Backporting for 2.2 (pr88) (2.2-develop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix Component: Catalog Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Corefix @piotrekkaminski @hshar7 @mmansoor-magento @vkorotun @MomotenkoNatalia @sshrewz