Move bunch of javascript variables from global scope to local scope in magnifier.js file

[hostep]

Description (*)

Due to a mistake in a 9 year old commit where a , was incorrectly changed to a ;, a bunch of JS variables became globally scoped and no longer scoped inside the local Magnify function.

This PR fixes that.

To better review the changes in this PR, please ignore whitespace changes: https://github.com/magento/magento2/pull/39321/files?w=1

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Magnifier.js syntax error #36200

Manual testing scenarios (*)

1. Have a Magento shop with a product with some images
2. Visit that product in the frontend
3. Open your browsers javascript console
4. Execute console.log(magnifierOptions);
5. Test the magnifier functionality on the product images

Expected:
4. Shouldn't work, magnifierOptions should not be available in global scope
5. Magnifier functionality should keep working the way it worked before

Questions or comments

I won't be updating/writing automated tests, because I have no idea how to do that in scope of this change. If that's required, please do it yourself :)

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @hostep. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[hostep]

@magento run all tests