Fixes: Bundle product with only one product in required bundle option not being added to cart with bundle option. #38601

bhoopatparmar · 2024-04-10T09:43:33Z

Description (*)

Adding a bundle product to the cart from the product list widget doesn’t let the product be added properly with the bundle option. The bundle product options are not added within the parent product. It shows a warning message in minicart like ‘Please specify product option(s)’. It doesn’t fail in all the cases, it only fails in a certain case where a bundle product has been created with a required bundle option & the bundle option contains only one product with the ‘is_default’ checkbox selected.

Screenshot 1:

Here you can see in the screenshot a bundle product has been created with a bundle option containing only one product in it & the option is required and the product is default select.

Screenshot 2:

After creating a bundle product, a widget has been created with a type of Catalog Product List & a condition that matches the particular bundle product.

Screenshot 3:

As we have created a widget, a bundle product is visible on the home page in the widget.

Screenshot 4:

When we click on the add-to-cart button, the product seems to be added to the cart & it doesn’t throw any error. And then if you check in the mini-cart, you will come to see a warning message like “Please specify product option(s).”

The same thing works fine on a list page, but it fails while adding a product to the cart through the widget.

Manual testing scenarios (*)

Create a bundle product that contains one or more bundle options & each bundle option is required and must contain only one product that is default selected. (see screenshot 1)
Create a widget with the type ‘Catalog Product List’ with a condition that includes the newly created bundle product in the widget. (see screenshot 2)
From the front end visit the widget & try to add the bundle product from the widget product list.(see screenshot 3)
After clicking Add to Cart observe a warning message in minicart. (see screenshot 4).

Expected result (*)

The bundle product should be added to the cart with bundle options.

Actual result (*)

The bundle product isn’t being added to the cart with bundle options.

Additional Information (*)

File1: Magento/CatalogWidget/view/frontend/templates/product/widget/content/grid.phtml
File2: Magento/Catalog/view/frontend/templates/product/list.phtml

If we check in the above-given list.phtml, it gets the option by using the ViewModel & which works fine on the list page. (see screenshot 5).
Screenshot 5:

In the given grid.phtml file it doesn’t get the options data where the add-to-cart form is rendered for the particular product (see screenshot 6). As the options are not rendered, adding that product to the cart will only add the parent bundle product to the cart without any bundle options. So, we need to implement the same thing as list.phtml to get the data in grid.phtml.

Screenshot 6:

Solution (*)

We have to update the given phtml to get the bundle options in the add-to-cart form. We can get the bundle product options by using the Magento\Catalog\ViewModel\Product\OptionsData ViewModel. (see screenshot 7)

A separate function has been created in the block file of the grid.phtml (Magento\CatalogWidget\Block\Product\ProductsList) to get the ViewModel that returns the object of Magento\Catalog\ViewModel\Product\OptionsData.

Screenshot 7:

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Fixes: Bundle product with only one product in required bundle option not being added to cart with bundle option. #38605: Fixes: Bundle product with only one product in required bundle option not being added to cart with bundle option.

Related Pull Requests

https://github.com/magento-gl/magento2-page-builder/pull/84

m2-assistant · 2024-04-10T09:43:37Z

Hi @bhoopatparmar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

bhoopatparmar · 2024-04-10T09:45:17Z

@magento run all tests

engcom-Hotel · 2024-04-10T13:44:03Z

@magento create issue

Bashev · 2024-04-10T20:15:30Z

app/code/Magento/CatalogWidget/view/frontend/templates/product/widget/content/grid.phtml

@@ -74,6 +74,12 @@ use Magento\Wishlist\Helper\Data;
                                                    <?php if ($_item->isSaleable()): ?>
                                                        <?php $postParams = $block->getAddToCartPostParams($_item); ?>
                                                        <form data-role="tocart-form" data-product-sku="<?= $escaper->escapeHtml($_item->getSku()) ?>" action="<?= $escaper->escapeUrl($postParams['action']) ?>" method="post">
+                                                            <?php $options = $block->getViewModel()->getOptionsData($_item); ?>


Will be complete solution if you add the same for the pagebuilder package (in their repository https://github.com/magento/magento2-page-builder) https://github.com/magento/magento2-page-builder/blob/4a2795ea9d2dae7cec8437e5e25e78e67c1b8d90/app/code/Magento/PageBuilder/view/frontend/templates/catalog/product/widget/content/carousel.phtml#L62

Same as here: https://github.com/magento/magento2-page-builder/pull/868/files#r1560503440
<?php $options = $block->getViewModel()->getOptionsData($_item); ?>
change it to
<?php if($options = $block->getViewModel()?->getOptionsData($_item)) : ?>
will prevent empty/not assigned viewModel

and ofc, close if, at the end of foreach.

@Bashev Thanks for your suggestion. I've updated the code as per your suggestion

Bashev

Looks fine for me.

engcom-Bravo · 2024-04-15T08:31:31Z

@magento run all tests

engcom-Bravo · 2024-04-15T09:55:38Z

@magento give me test instance

magento-deployment-service · 2024-04-15T09:55:42Z

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2024-04-15T10:03:05Z

Hi @engcom-Bravo, here is your Magento Instance: https://28ee115254eb32b2e9f687bedaaa2ba2.instances-prod.magento-community.engineering
Admin access: https://28ee115254eb32b2e9f687bedaaa2ba2.instances-prod.magento-community.engineering/admin_9032
Login: 4c17029c
Password: 201f1ec6f2f6

engcom-Bravo

Hi @bhoopatparmar,

Thanks for the collaboration & contribution!

❌ QA not Passed

Manual Scenario Steps

Create a bundle product that contains one or more bundle options & each bundle option is required and must contain only one product that is default selected. (see screenshot 1)
Create a widget with the type ‘Catalog Product List’ with a condition that includes the newly created bundle product in the widget. (see screenshot 2)
From the front end visit the widget & try to add the bundle product from the widget product list.(see screenshot 3)
After clicking Add to Cart observe a warning message in minicart. (see screenshot 4).

✔️ Expected result After Fix

The bundle product should be added to the cart with bundle options

❌ Actual result After Fix

Bundle Products are still not adding to the cart with the Bundle options.

Could you please let us know if we are missing anything.

Thanks.

engcom-Echo · 2024-07-01T11:42:20Z

@magento give me test instance

magento-deployment-service · 2024-07-01T11:42:24Z

Hi @engcom-Echo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2024-07-01T11:49:36Z

Hi @engcom-Echo, here is your Magento Instance: https://28ee115254eb32b2e9f687bedaaa2ba2.instances-prod.magento-community.engineering
Admin access: https://28ee115254eb32b2e9f687bedaaa2ba2.instances-prod.magento-community.engineering/admin_88fa
Login: 9923f9b4
Password: 5f30b4efc455

engcom-Echo · 2024-07-04T11:30:19Z

@magento run all tests

engcom-Echo · 2024-07-04T11:45:14Z

@magento run all tests

engcom-Echo · 2024-07-04T13:48:33Z

@magento run all tests

engcom-Bravo

Hi @bhoopatparmar,

Thanks for Contribution!!.

Could you please resolve conflicts to proceed further with the PR.

Thanks.

bhoopatparmar · 2024-07-08T08:03:20Z

Hi @engcom-Bravo
The solution has been merged in the dev branch by in this commit: d921385
Hence closing this PR
Thank you

Fixed issue with product options in product list widget

d7df3a5

engcom-Hotel added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Apr 10, 2024

m2-community-project bot added the Progress: pending review label Apr 10, 2024

m2-assistant bot mentioned this pull request Apr 10, 2024

[Issue] Fixes: Bundle product with only one product in required bundle option not being added to cart with bundle option. #38605

Closed

5 tasks

Bashev reviewed Apr 10, 2024

View reviewed changes

m2-community-project bot assigned Bashev Apr 10, 2024

m2-community-project bot added Progress: review and removed Progress: pending review labels Apr 10, 2024

bhoopatparmar mentioned this pull request Apr 11, 2024

Fixes: Bundle product with only one product in required bundle option not being added to cart with bundle option magento/magento2-page-builder#868

Closed

6 tasks

prevents nullable (not defined) viewModel

8c3b2f6

Bashev approved these changes Apr 11, 2024

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Apr 11, 2024

engcom-Bravo self-assigned this Apr 15, 2024

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Apr 15, 2024

Merge branch '2.4-develop' into bundle-product

9042f4c

engcom-Bravo requested changes Apr 15, 2024

View reviewed changes

magento deleted a comment from magento-deployment-service bot Jul 1, 2024

Automated test coverage added

94ba008

Added after steps in test coverage to make setting default

5a7a014

m2-community-project bot added Progress: pending review and removed Progress: needs update labels Jul 5, 2024

m2-community-project bot added Progress: review and removed Progress: pending review labels Jul 5, 2024

engcom-Hotel approved these changes Jul 5, 2024

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Jul 5, 2024

engcom-Bravo requested changes Jul 8, 2024

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Jul 8, 2024

bhoopatparmar closed this Jul 8, 2024

m2-community-project bot removed the Progress: needs update label Jul 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes: Bundle product with only one product in required bundle option not being added to cart with bundle option. #38601

Fixes: Bundle product with only one product in required bundle option not being added to cart with bundle option. #38601

bhoopatparmar commented Apr 10, 2024 •

edited by engcom-Echo

Loading

m2-assistant bot commented Apr 10, 2024

bhoopatparmar commented Apr 10, 2024

engcom-Hotel commented Apr 10, 2024

Bashev Apr 10, 2024 •

edited

Loading

Bashev Apr 11, 2024

bhoopatparmar Apr 11, 2024

Bashev left a comment

engcom-Bravo commented Apr 15, 2024

engcom-Bravo commented Apr 15, 2024

magento-deployment-service bot commented Apr 15, 2024

magento-deployment-service bot commented Apr 15, 2024

engcom-Bravo left a comment •

edited

Loading

engcom-Echo commented Jul 1, 2024

magento-deployment-service bot commented Jul 1, 2024

magento-deployment-service bot commented Jul 1, 2024

engcom-Echo commented Jul 4, 2024

engcom-Echo commented Jul 4, 2024

engcom-Echo commented Jul 4, 2024

engcom-Bravo left a comment

bhoopatparmar commented Jul 8, 2024

Fixes: Bundle product with only one product in required bundle option not being added to cart with bundle option. #38601

Fixes: Bundle product with only one product in required bundle option not being added to cart with bundle option. #38601

Conversation

bhoopatparmar commented Apr 10, 2024 • edited by engcom-Echo Loading

Description (*)

Manual testing scenarios (*)

Expected result (*)

Actual result (*)

Additional Information (*)

Solution (*)

Contribution checklist (*)

Resolved issues:

Related Pull Requests

m2-assistant bot commented Apr 10, 2024

bhoopatparmar commented Apr 10, 2024

engcom-Hotel commented Apr 10, 2024

Bashev Apr 10, 2024 • edited Loading

Choose a reason for hiding this comment

Bashev Apr 11, 2024

Choose a reason for hiding this comment

bhoopatparmar Apr 11, 2024

Choose a reason for hiding this comment

Bashev left a comment

Choose a reason for hiding this comment

engcom-Bravo commented Apr 15, 2024

engcom-Bravo commented Apr 15, 2024

magento-deployment-service bot commented Apr 15, 2024

magento-deployment-service bot commented Apr 15, 2024

engcom-Bravo left a comment • edited Loading

Choose a reason for hiding this comment

engcom-Echo commented Jul 1, 2024

magento-deployment-service bot commented Jul 1, 2024

magento-deployment-service bot commented Jul 1, 2024

engcom-Echo commented Jul 4, 2024

engcom-Echo commented Jul 4, 2024

engcom-Echo commented Jul 4, 2024

engcom-Bravo left a comment

Choose a reason for hiding this comment

bhoopatparmar commented Jul 8, 2024

bhoopatparmar commented Apr 10, 2024 •

edited by engcom-Echo

Loading

Bashev Apr 10, 2024 •

edited

Loading

engcom-Bravo left a comment •

edited

Loading