Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop screen loader on payment error #3749

Merged
merged 1 commit into from
Aug 12, 2016
Merged

Stop screen loader on payment error #3749

merged 1 commit into from
Aug 12, 2016

Conversation

ytorbyk
Copy link
Member

@ytorbyk ytorbyk commented Mar 12, 2016

Steps to reproduce:

  • In backend - configure PayPal Payments Pro (Includes Express Checkout)
  • Go to the frontend, login and add any product to the shopping cart
  • Go to checkout page and choose Credit Cart (PayPal Payments Pro)
  • Enter required values (I used data for sandbox)
  • Click on Place Order button

Expected:

  • Order is placed

Actual:

  • Error message occured: Cannot place order (and disappeared in couple seconds). But screen loader is not hidden, message is under loader.

Fix for the cause of the error is proposed in PR 3748

@ishakhsuvarov ishakhsuvarov self-assigned this Mar 14, 2016
@piotrekkaminski
Copy link
Contributor

internal issue MAGETWO-54362

@hshar7
Copy link
Contributor

hshar7 commented Jul 28, 2016

@ytorbyk Could you please sign CLA agreement. We cannot continue processing this pr without having you sign it.

@vkorotun vkorotun added the bugfix label Aug 5, 2016
@sshrewz sshrewz added the linked label Aug 11, 2016
@mmansoor-magento mmansoor-magento merged commit f66e6f4 into magento:develop Aug 12, 2016
mmansoor-magento pushed a commit that referenced this pull request Aug 12, 2016
@irenelagno
MAGETWO-54362: [Github] Stop screen loader on payment error #3749
c6e99b9
mmansoor-magento pushed a commit that referenced this pull request Aug 12, 2016
@irenelagno
MAGETWO-54362: [Github] Stop screen loader on payment error #3749
2bf419c
mmansoor-magento pushed a commit that referenced this pull request Aug 12, 2016
@irenelagno
MAGETWO-54362: [Github] Stop screen loader on payment error #3749
2f9ecce
mmansoor-magento pushed a commit that referenced this pull request Aug 12, 2016
@irenelagno
MAGETWO-54362: [Github] Stop screen loader on payment error #3749
a452400
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
bugfix Component: Checkout Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept Progress: needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ytorbyk @piotrekkaminski @hshar7 @vasiliyseleznev @mmansoor-magento @ishakhsuvarov @vkorotun @sshrewz