Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed CliIndexerReindexActionGroup action group usage for CatalogSearch module #31592

Merged
merged 4 commits into from
Jan 30, 2021
Merged

Removed CliIndexerReindexActionGroup action group usage for CatalogSearch module #31592

merged 4 commits into from
Jan 30, 2021

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Jan 8, 2021 •
edited by m2-assistant bot
Loading

Description

Remove CliIndexerReindexActionGroup action group usage from tests to improve execution time for the CatalogSearch module.

Resolved issues:

  1. resolves [Issue] [WIP] Removed CliIndexerReindexActionGroup action group usage for CatalogSearch module #31628: [WIP] Removed CliIndexerReindexActionGroup action group usage for CatalogSearch module

@m2-assistant
Copy link

m2-assistant bot commented Jan 8, 2021

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: CatalogSearch Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 8, 2021
@sergiy-v
Copy link
Contributor Author

sergiy-v commented Jan 8, 2021

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B,Semantic Version Checker

@rogyar rogyar self-assigned this Jan 8, 2021
@rogyar
Copy link
Contributor

rogyar commented Jan 8, 2021

Hi @sergiy-v. It looks like the failing ElasticSearch functional tests might be related to your changes

@sergiy-v
Copy link
Contributor Author

sergiy-v commented Jan 8, 2021

Hi @sergiy-v. It looks like the failing ElasticSearch functional tests might be related to your changes

@rogyar thanks, will check it.

@sergiy-v sergiy-v changed the title Removed CliIndexerReindexActionGroup action group usage for CatalogSearch module [WIP] Removed CliIndexerReindexActionGroup action group usage for CatalogSearch module Jan 8, 2021
@sergiy-v
Copy link
Contributor Author

sergiy-v commented Jan 9, 2021

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jan 12, 2021
@sidolov
Copy link
Contributor

sidolov commented Jan 12, 2021

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jan 12, 2021
Closed
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B,Semantic Version Checker

@sergiy-v sergiy-v force-pushed the mftf-CliIndexerReindexActionGroup-usage-catalog-search branch from a6276f6 to 2d152d2 Compare January 13, 2021 09:24
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

@sergiy-v
Copy link
Contributor Author

All Functional tests are green.
@rogyar please proceed with checking.
Thank you.

@sergiy-v sergiy-v changed the title [WIP] Removed CliIndexerReindexActionGroup action group usage for CatalogSearch module Removed CliIndexerReindexActionGroup action group usage for CatalogSearch module Jan 20, 2021
@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 23, 2021
@engcom-Delta
Copy link
Contributor

Note: QA not applicable

@engcom-Delta
Copy link
Contributor

Note: Some tests are waiting for status

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jan 25, 2021
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

2 similar comments
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

@sergiy-v sergiy-v force-pushed the mftf-CliIndexerReindexActionGroup-usage-catalog-search branch from 2d152d2 to d896a8d Compare January 27, 2021 06:52
@sergiy-v
Copy link
Contributor Author

@magento run all tests

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests B2B

magento-engcom-team pushed a commit that referenced this pull request Jan 30, 2021
@gabrieldagama
ENGCOM-8695: Removed CliIndexerReindexActionGroup action group usage …
2f3ac24 
…for CatalogSearch module #31592
@magento-engcom-team magento-engcom-team merged commit 36e15e9 into magento:2.4-develop Jan 30, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jan 30, 2021

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: CatalogSearch Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Type: Test Coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [WIP] Removed CliIndexerReindexActionGroup action group usage for CatalogSearch module
7 participants
@sergiy-v @rogyar @sidolov @magento-engcom-team @engcom-Delta @engcom-Foxtrot @gabrieldagama