Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Adding AdminFillTaxIdentifierFilterOnTaxRateGridActionGroup #31454

Merged
merged 4 commits into from
Feb 5, 2021
Merged

[MFTF] Adding AdminFillTaxIdentifierFilterOnTaxRateGridActionGroup #31454

merged 4 commits into from
Feb 5, 2021

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Dec 24, 2020 •
edited
Loading

Description (*)

AdminFillTaxIdentifierFilterOnTaxRateGridActionGroup has been added
Tests have been updated with AdminFillTaxIdentifierFilterOnTaxRateGridActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2020

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Tax Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 24, 2020
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@AnnaAPak AnnaAPak changed the title [MFTF] Updating with AdminFilterTaxRateByCodeActionGroup WIP.[MFTF] Updating with AdminFilterTaxRateByCodeActionGroup Dec 24, 2020
@AnnaAPak AnnaAPak force-pushed the upd-AdminFilterTaxRateByCodeActionGroup branch from 7228847 to 63578f5 Compare December 24, 2020 14:05
@AnnaAPak AnnaAPak force-pushed the upd-AdminFilterTaxRateByCodeActionGroup branch from 63578f5 to 8fde38b Compare December 24, 2020 14:08
@AnnaAPak AnnaAPak changed the title WIP.[MFTF] Updating with AdminFilterTaxRateByCodeActionGroup [MFTF] Adding AdminFillTaxIdentifierFilterOnTaxRateGridActionGroup Dec 24, 2020
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@eduard13 eduard13 self-assigned this Jan 4, 2021
@eduard13 eduard13 self-requested a review January 4, 2021 08:21
@eduard13 eduard13 added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jan 4, 2021
@eduard13 eduard13 added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 4, 2021
@eduard13
Copy link
Contributor

eduard13 commented Jan 4, 2021

@magento run all tests

eduard13
eduard13 reviewed Jan 4, 2021
View reviewed changes
app/code/Magento/Tax/Test/Mftf/Test/UpdateLargeTaxRateEntityTest.xml
@@ -44,8 +46,9 @@
<!-- Verify we see updated large tax rate(from the above step) on the tax rate grid page -->
<actionGroup ref="AdminTaxRateGridOpenPageActionGroup" stepKey="goToTaxRateIndex4"/>
<click selector="{{AdminDataGridHeaderSection.clearFilters}}" stepKey="clickClearFilters2"/>
<fillField selector="{{AdminTaxRateGridSection.filterByTaxIdentifier}}" userInput="{{defaultTaxRateWithLargeRate.code}}" stepKey="fillTaxIdentifierField3"/>
<click selector="{{AdminTaxRateGridSection.search}}" stepKey="clickSearch2"/>
Copy link
Contributor

@eduard13 eduard13 Jan 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should preserve the clickSearch2 reference, this is the reason of the SVC failing.

@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Jan 4, 2021

@magento run all tests

eduard13
eduard13 approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests aren't related to these changes.

gabrieldagama
gabrieldagama suggested changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnnaAPak, can you have a look at the conflicts? Thank you!

@AnnaAPak
Copy link
Contributor Author

@magento run all tests

2 similar comments
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@eduard13
Copy link
Contributor

@magento run Functional Tests B2B , Functional Tests CE, Functional Tests EE

eduard13
eduard13 approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failed tests don't seem to be related to the failed functional tests

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-8594 has been created to process this Pull Request

magento-engcom-team pushed a commit that referenced this pull request Feb 5, 2021
@gabrieldagama
ENGCOM-8594: [MFTF] Adding AdminFillTaxIdentifierFilterOnTaxRateGridA…
d29db5c 
…ctionGroup #31454
@magento-engcom-team magento-engcom-team merged commit af88377 into magento:2.4-develop Feb 5, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 5, 2021

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldagama gabrieldagama gabrieldagama requested changes

@eduard13 eduard13 eduard13 approved these changes

Assignees

@gabrieldagama gabrieldagama

@eduard13 eduard13

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Tax Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AnnaAPak @eduard13 @magento-engcom-team @engcom-Alfa @engcom-Foxtrot @gabrieldagama