Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MFTF] Adding AdminSelectAttributeSetOnEditProductPageActionGroup #31287

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Dec 15, 2020

Description (*)

Adding AdminSelectAttributeSetOnEditProductPageActionGroup

Resolved issues:

  1. resolves [Issue] [MFTF] Adding AdminSelectAttributeSetOnEditProductPageActionGroup #31290: [MFTF] Adding AdminSelectAttributeSetOnEditProductPageActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Dec 15, 2020

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Bundle Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 15, 2020
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests EE

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Dec 15, 2020
@sidolov
Copy link
Contributor

sidolov commented Dec 15, 2020

@magento create issue

@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnnaAPak could you please check the minor comment that I left?
Thank you.

@eduard13 eduard13 added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 16, 2020
Merge branch 'ref-AdminChangeProductAttributeSetTes' of github.com:AnnaAPak/magento2 into ref-AdminChangeProductAttributeSetTes
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@AnnaAPak
Copy link
Contributor Author

@eduard13 can you please take a look one more time? Thank you.

@eduard13
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel self-assigned this Dec 18, 2020
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE

1 similar comment
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE

@engcom-Alfa
Copy link
Contributor

QA not applicable

@m2-assistant
Copy link

m2-assistant bot commented Dec 23, 2020

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Bundle Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Adding AdminSelectAttributeSetOnEditProductPageActionGroup
6 participants