#31168 fix for customer which have more than two subscriptions

[korovitskyi]

Description (*)

Rolled back updating is_subscribed Extension attribute at Magento\Customer\Api\Data\CustomerInterface.
And test for this case was added.
Column reference_field must be unique to avoid exceptions on getList method.

Fixed Issues
Fixes #31168.

Manual testing scenarios (*)

1. Create customer.
2. Add several(more then one) newsletter subscriptions for this customer.
3. Get this customer by \Magento\Customer\Api\CustomerRepositoryInterface::getList method.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @korovitskyi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[swnsma]

Hi @korovitskyi!
Thank you for your contribution.
I am afraid that such changes could be considered backward-incompatible for those who are using the 'is_subscribed' extension attribute.

With new behavior, we will receive a list of customers without these values.
My suggestion is to adjust logic inside 'app/code/Magento/Newsletter/Model/Plugin/CustomerPlugin' by using a subscribers collection to fill the required data.
What do you think about this?

[engcom-Charlie]

Hi @korovitskyi could you please look at #31261 (review)?
Thank you.

[korovitskyi]

Hi, @swnsma, @engcom-Charlie.
Thanks for notice.
Changes was sent.
Please, let me know if you have some notes.

[swnsma]

@magento run all tests

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-8551 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Preconditions:

1. Admin -> Stores -> Configuration -> Customers -> Customer Configuration -> Account Sharing Options and set Share Customer Accounts to Global

2. Multiple-store views setup in Magento

3. Have one customer ( [email protected] for ex.);

Steps to reproduce (*)

1. Go to Admin -> Customers -> All Customers and open customer for edit;
2. On left side, select Newsletter, to have the Newsletter Informaiton panel where all stores views are displayed.
3. Select more than 1 checkbox to subscriber customer to the store's newsletter and save customer
   (at this point, in Newsletter Subscribers view, customer is subscribed to newsletter for multiple-store views)

4. Use REST to call GET /V1/customers/search to retrieve the customer

V1/customers/search?searchCriteria[filterGroups][0][filters][0][field]=email&searchCriteria[filterGroups][0][filters][0][value]=[email protected]&searchCriteria[filterGroups][0][filters][0][conditionType]=eq

Before: ✖️ Exception occurs.

And in the exception.log file:

After: ✔️ Customer details are returned correctly

[m2-assistant]

Hi @korovitskyi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[robbie-thompson]

@korovitskyi we just ran into this error, thanks for fixing this! 🙌