-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MFTF] Refactoring of AdminMassOrdersCancelCompleteAndClosedTest #31123
[MFTF] Refactoring of AdminMassOrdersCancelCompleteAndClosedTest #31123
Conversation
Please enter the commit message for your changes. Lines starting
Hi @AnnaAPak. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AnnaAPak. Awesome piece of work!
Please, check my suggestion regarding the naming.
|
||
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd"> | ||
<test name="AdminMassOrdersCancelCompleteAndClosedAPITest"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest removing the API keyword from the test name. Despite the fact we create entities via API, we test the admin UI behavior eventually (not the API). For API we have a different type of tests.
<test name="AdminMassOrdersCancelCompleteAndClosedAPITest"> | |
<test name="AdminMassOrdersCancelCompleteAndClosedAPITest"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rogyar, I have renamed the test. Thank you!
Hi @rogyar, thank you for the review. |
Note: QA not applicable |
@magento run all tests |
Hi @AnnaAPak, thank you for your contribution! |
Description (*)
A new test has been created according to the best practices followed by MFTF.
The old "AdminMassOrdersCancelCompleteAndClosedTest" has been deprecated.
Manual testing scenarios (*)
Resolved issues: