[MFTF] Refactoring of AddOutOfStockProductToCompareListTest #31099

AnnaAPak · 2020-11-30T15:39:14Z

Description (*)

The test is refactored according to the best practices followed by MFTF.

Manual testing scenarios (*)

Create an out of stock product
Disable the "Display Out of Stock Products" option
Open the PDP
Check if the "Add to compare" link isn't available
Enable the "Display Out of Stock Products" option
Open the PDP
Check if the "Add to compare" link is available
Add product to the Comparison list
Go to the Comparison list and check if the product is displayed there
Clear the Comparison list
Go to the product's category
Hover the product
Add product to the Comparison list
Go to theComparison list and check if the product is displayed there

Resolved issues:

resolves [Issue] [MFTF] Refactoring of AddOutOfStockProductToCompareListTest #31131: [MFTF] Refactoring of AddOutOfStockProductToCompareListTest

Merge branch '2.4-develop' into ref-AddOutOfStockProductToCompareListTest

m2-assistant · 2020-11-30T15:39:16Z

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

AnnaAPak · 2020-11-30T15:39:40Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

rogyar

Hi @AnnaAPak. Looks good. There are some minor suggestions. Please, check them out.

Thanks

rogyar · 2020-11-30T18:35:29Z

app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml

        <after>
-            <magentoCLI command="config:set {{CatalogInventoryOptionsShowOutOfStockDisable.path}} {{CatalogInventoryOptionsShowOutOfStockDisable.value}}" stepKey="setConfigShowOutOfStockFalse"/>
+           <magentoCLI command="config:set {{CatalogInventoryOptionsShowOutOfStockDisable.path}} {{CatalogInventoryOptionsShowOutOfStockDisable.value}}" stepKey="setConfigShowOutOfStockFalse"/> 


Please, check the trailing spaces at the end

Also, please, make sure we have a correct indentation for this line of code.

Corrected, thank you.

rogyar · 2020-11-30T19:43:57Z

...de/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontHoverProductOnCategoryPageActionGroup.xml

+            <description>Hover product on the Category page</description>
+        </annotations>
+
+    <moveMouseOver selector="{{StorefrontCategoryMainSection.ProductItemInfo}}" stepKey="hoverOverProduct"/>


Please, make sure we have a correct indentation here and everywhere throughout the code.

Corrected and re-checked throughout the code. Thanks.

magento-engcom-team · 2020-12-16T16:42:46Z

Hi @sidolov, thank you for the review.
ENGCOM-8547 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Bravo · 2020-12-17T08:31:35Z

QA not applicable for MFTF Refactoring PR-s. Moving it to Extended Testing column

engcom-Foxtrot · 2020-12-17T14:05:37Z

@magento run all tests

…tTest.

engcom-Foxtrot · 2020-12-18T09:53:17Z

@magento run all tests

…est #31099

m2-assistant · 2020-12-23T05:06:52Z

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

AnnaAPak added 4 commits November 6, 2020 18:37

AddOutOfStockProductToCompareListTest refactored

6bb8158

update with 2.4-develop

3cf82b7

Merge branch '2.4-develop' into ref-AddOutOfStockProductToCompareListTest

restoring stepKeys

1089f15

refactored

7320189

magento-engcom-team added Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 30, 2020

AnnaAPak changed the title ~~Refactoring of AddOutOfStockProductToCompareListTest~~ [MFTF] Refactoring of AddOutOfStockProductToCompareListTest Nov 30, 2020

m2-community-project bot added the Progress: pending review label Nov 30, 2020

rogyar self-assigned this Nov 30, 2020

m2-community-project bot added Progress: review and removed Progress: pending review labels Nov 30, 2020

rogyar requested changes Nov 30, 2020

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Nov 30, 2020

AnnaAPak added 2 commits December 1, 2020 08:57

fixed indentation

8ba2695

fixed indentation

d001c99

m2-community-project bot added Progress: review and removed Progress: needs update labels Dec 1, 2020

sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Dec 2, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Dec 16, 2020

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 17, 2020

m2-community-project bot added the Progress: extended testing label Dec 17, 2020

engcom-Foxtrot self-assigned this Dec 17, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: extended testing Progress: testing in progress labels Dec 17, 2020

m2-community-project bot added Progress: extended testing and removed Progress: ready for testing labels Dec 17, 2020

magento#31131: [MFTF] Refactoring of AddOutOfStockProductToCompareLis…

125b01a

…tTest.

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Dec 21, 2020

magento-engcom-team pushed a commit that referenced this pull request Dec 23, 2020

ENGCOM-8547: [MFTF] Refactoring of AddOutOfStockProductToCompareListT…

95be919

…est #31099

magento-engcom-team merged commit 3a9ac72 into magento:2.4-develop Dec 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MFTF] Refactoring of AddOutOfStockProductToCompareListTest #31099

[MFTF] Refactoring of AddOutOfStockProductToCompareListTest #31099

AnnaAPak commented Nov 30, 2020 •

edited by m2-assistant bot

Loading

m2-assistant bot commented Nov 30, 2020

AnnaAPak commented Nov 30, 2020

rogyar left a comment

rogyar Nov 30, 2020

rogyar Nov 30, 2020

AnnaAPak Dec 1, 2020

rogyar Nov 30, 2020

AnnaAPak Dec 1, 2020

magento-engcom-team commented Dec 16, 2020

engcom-Bravo commented Dec 17, 2020

engcom-Foxtrot commented Dec 17, 2020

engcom-Foxtrot commented Dec 18, 2020

m2-assistant bot commented Dec 23, 2020

[MFTF] Refactoring of AddOutOfStockProductToCompareListTest #31099

[MFTF] Refactoring of AddOutOfStockProductToCompareListTest #31099

Conversation

AnnaAPak commented Nov 30, 2020 • edited by m2-assistant bot Loading

Description (*)

Manual testing scenarios (*)

Resolved issues:

m2-assistant bot commented Nov 30, 2020

AnnaAPak commented Nov 30, 2020

rogyar left a comment

Choose a reason for hiding this comment

rogyar Nov 30, 2020

Choose a reason for hiding this comment

rogyar Nov 30, 2020

Choose a reason for hiding this comment

AnnaAPak Dec 1, 2020

Choose a reason for hiding this comment

rogyar Nov 30, 2020

Choose a reason for hiding this comment

AnnaAPak Dec 1, 2020

Choose a reason for hiding this comment

magento-engcom-team commented Dec 16, 2020

engcom-Bravo commented Dec 17, 2020

engcom-Foxtrot commented Dec 17, 2020

engcom-Foxtrot commented Dec 18, 2020

m2-assistant bot commented Dec 23, 2020

AnnaAPak commented Nov 30, 2020 •

edited by m2-assistant bot

Loading