Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Refactoring of AdminMassUpdateProductAttributesMissingRequiredFieldTest #31079

Merged
merged 2 commits into from
Dec 10, 2020
Merged

[MFTF] Refactoring of AdminMassUpdateProductAttributesMissingRequiredFieldTest #31079

merged 2 commits into from
Dec 10, 2020

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Nov 27, 2020 •
edited by m2-assistant bot
Loading

Description (*)

The test is refactored according to the best practices followed by MFTF.

Manual testing scenarios (*)

  1. Create 2 simple products
  2. Go to Admin->Catalog->Products
  3. Request mass update for product name
  4. Do not fill the "Product Name"
  5. Check if the "Product Name" field is required

Resolved issues:

  1. resolves [Issue] [MFTF] Refactoring of AdminMassUpdateProductAttributesMissingRequiredFieldTest #31160: [MFTF] Refactoring of AdminMassUpdateProductAttributesMissingRequiredFieldTest

@m2-assistant
Copy link

m2-assistant bot commented Nov 27, 2020

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 27, 2020
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@eduard13 eduard13 self-assigned this Nov 27, 2020
@eduard13 eduard13 self-requested a review November 27, 2020 15:46
@eduard13
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

eduard13
eduard13 requested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnnaAPak, thank you for the improvement, could you please check the below minor suggestions?
Thanks.

...nto/Catalog/Test/Mftf/ActionGroup/AdminClickSaveOnProductsMassAttributeUpdateActionGroup.xml
<description>Clicks on 'Save' button on products mass attributes update page.</description>
</annotations>

<click selector="{{AdminEditProductAttributesSection.Save}}" stepKey="save"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you save something, is much better to make sure the page is loaded afterwards waitForPageLoad, including a success/error message if that's the case.
Also please remove the empty rows in your changed files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eduard13 thank you for the advice - this has been addressed.

...nto/Catalog/Test/Mftf/ActionGroup/AdminClickSaveOnProductsMassAttributeUpdateActionGroup.xml Outdated
<click selector="{{AdminEditProductAttributesSection.Save}}" stepKey="save"/>

</actionGroup>
</actionGroups>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preserve an empty row at the end of the file.

Suggested change
</actionGroups>
</actionGroups>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty row has been added, thanks.

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminCheckProductOnProductGridActionGroup.xml Outdated
<checkOption selector="{{AdminProductGridSection.productRowCheckboxBySku(product.sku)}}" stepKey="selectProduct"/>

</actionGroup>
</actionGroups>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</actionGroups>
</actionGroups>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty row has been added, thanks.

...talog/Test/Mftf/ActionGroup/AdminCheckNameToggleOnProductsMassAttributeUpdateActionGroup.xml Outdated
<click selector="{{AdminEditProductAttributesSection.ChangeAttributeNameToggle}}" stepKey="toggleToChangeName"/>

</actionGroup>
</actionGroups>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</actionGroups>
</actionGroups>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty row has been added, thanks.

@eduard13 eduard13 added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 30, 2020
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@eduard13
Copy link
Contributor

eduard13 commented Dec 1, 2020

@magento run Functional Tests CE, Functional Tests B2B

@eduard13
Copy link
Contributor

eduard13 commented Dec 1, 2020

@magento run all tests

eduard13
eduard13 approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 👍
The failed test doesn't seem to be related to these changes.

@engcom-Delta
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Dec 4, 2020
Closed
@engcom-Delta
Copy link
Contributor

Note: QA not applicable

@engcom-Delta
Copy link
Contributor

Note: Functional Tests B2B are failed

@engcom-Charlie engcom-Charlie self-assigned this Dec 4, 2020
magento-engcom-team pushed a commit that referenced this pull request Dec 10, 2020
@gabrieldagama
ENGCOM-8511: [MFTF] Refactoring of AdminMassUpdateProductAttributesMi…
f7523fb 
…ssingRequiredFieldTest #31079
@magento-engcom-team magento-engcom-team merged commit ec3b6f0 into magento:2.4-develop Dec 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2020

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

Assignees

@eduard13 eduard13

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Refactoring of AdminMassUpdateProductAttributesMissingRequiredFieldTest
5 participants
@AnnaAPak @eduard13 @magento-engcom-team @engcom-Delta @engcom-Charlie