Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove clearing cache for integration tests #31053

Merged
merged 10 commits into from
Dec 22, 2020
Merged

remove clearing cache for integration tests #31053

merged 10 commits into from
Dec 22, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Nov 25, 2020 •
edited by m2-assistant bot
Loading

Removed CacheCleaner::cleanAll(); for integration tests

Resolved issues:

  1. resolves [Issue] [WIP] remove clearing cache for integration tests #31074: [WIP] remove clearing cache for integration tests

@m2-assistant
Copy link

m2-assistant bot commented Nov 25, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 25, 2020
@Usik2203
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Nov 25, 2020
@Usik2203
Copy link
Contributor Author

@magento run Integration Tests

ihor-sviziev
ihor-sviziev requested changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Usik2203,
Please check failing tests and fix them

@gabrieldagama gabrieldagama added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 26, 2020
@gabrieldagama
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Nov 26, 2020
Closed
@Usik2203
Copy link
Contributor Author

@magento run WebAPI Tests

ihor-sviziev
ihor-sviziev requested changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's a good idea to deprecate using the method CacheCleaner::cleanAll()?

dev/tests/api-functional/testsuite/Magento/GraphQl/CatalogUrlRewrite/UrlResolverTest.php
//modifying query by adding spaces to avoid getting cached values.
$this->queryUrlAndAssertResponse(
(int) $product->getEntityId(),
$customUrl,
$customUrl . ' ',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why this change was added and why it wasn't needed earlier?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added as described in comment https://github.com/magento/magento2/pull/31053/files/9ec34d8ca0a27ba9e34d8ad4803b6217175605d9#diff-e996da3d86e3da3160dd34c221e07fd9c45874f3ea3795b574e7e09ed004fad3R222
Since earlier we use CacheCleaner::cleanAll() and we got not cached response.

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B

ihor-sviziev
ihor-sviziev approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests looks not related to changes form this PR.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8529 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ihor-sviziev ihor-sviziev added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 8, 2020
@engcom-Alfa engcom-Alfa self-assigned this Dec 10, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

magento-engcom-team pushed a commit that referenced this pull request Dec 22, 2020
@gabrieldagama
ENGCOM-8529: remove clearing cache for integration tests #31053
110a361
@magento-engcom-team magento-engcom-team merged commit 0b3e124 into magento:2.4-develop Dec 22, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 22, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Charlie engcom-Charlie engcom-Charlie left review comments

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [WIP] remove clearing cache for integration tests
7 participants
@Usik2203 @gabrieldagama @engcom-Hotel @engcom-Charlie @ihor-sviziev @magento-engcom-team @engcom-Alfa