Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Adding AdminFillAccountInformationOnCreateOrderPageActionGroup #30986

Merged
merged 3 commits into from
Dec 21, 2020
Merged

[MFTF] Adding AdminFillAccountInformationOnCreateOrderPageActionGroup #30986

merged 3 commits into from
Dec 21, 2020

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Nov 19, 2020 •
edited by m2-assistant bot
Loading

This PR provides new AdminFillAccountInformationOnCreateOrderPageActionGroup

Resolved issues:

  1. resolves [Issue] [MFTF] Adding AdminFillAccountInformationOnCreateOrderPageActionGroup #31039: [MFTF] Adding AdminFillAccountInformationOnCreateOrderPageActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Nov 19, 2020

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Sales Component: Tax Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 19, 2020
@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@AnnaAPak AnnaAPak changed the title Adding AdminFillAccountInformationOnCreateOrderPageActionGroup [MFTF] Adding AdminFillAccountInformationOnCreateOrderPageActionGroup Nov 19, 2020
@rogyar rogyar self-assigned this Nov 19, 2020
rogyar
rogyar requested changes Nov 19, 2020
View reviewed changes
app/code/Magento/Sales/Test/Mftf/Test/AdminAvailabilityCreditMemoWithNoPaymentTest.xml Outdated
@@ -61,8 +61,10 @@
<click selector="{{AdminOrderFormItemsSection.updateItemsAndQuantities}}" stepKey="clickUpdateItemsAndQuantitiesButton"/>

<!--Fill customer group and customer email-->
<selectOption selector="{{AdminOrderFormAccountSection.group}}" userInput="{{GeneralCustomerGroup.code}}" stepKey="selectCustomerGroup"/>
<fillField selector="{{AdminOrderFormAccountSection.email}}" userInput="{{Simple_US_Customer.email}}" stepKey="fillCustomerEmail"/>
<comment userInput="Fill Account Information" stepKey="selectCustomerGroup"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnnaAPak. Good job, but I would ask you to highlight that he comment was added for preserving backward compatibility. Something like the following one

Suggested change
<comment userInput="Fill Account Information" stepKey="selectCustomerGroup"/>
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="selectCustomerGroup"/>

Otherwise this comment might be removed as "unnecessary" in the future and BC will be broken.

Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the comments as per the recommendation. Thank you.

@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@gabrieldagama gabrieldagama added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 24, 2020
@gabrieldagama
Copy link
Contributor

@magento create issue

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8495 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Nov 30, 2020
@engcom-Delta
Copy link
Contributor

Note: QA not applicable

@engcom-Delta
Copy link
Contributor

Note: Functional Tests B2B are failed, some tests are waiting for status

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 30, 2020
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

magento-engcom-team pushed a commit that referenced this pull request Dec 21, 2020
@sidolov
ENGCOM-8495: [MFTF] Adding AdminFillAccountInformationOnCreateOrderPa…
c7ba480 
…geActionGroup #30986
@magento-engcom-team magento-engcom-team merged commit 716cf83 into magento:2.4-develop Dec 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 21, 2020

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Sales Component: Tax Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Adding AdminFillAccountInformationOnCreateOrderPageActionGroup
6 participants
@AnnaAPak @gabrieldagama @magento-engcom-team @engcom-Delta @engcom-Foxtrot @rogyar