Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid binding magnifier events in duplicate on resize #30695

Merged

Commits on Oct 28, 2020

  1. Avoid binding events in duplicate

    This is particularly important as a resize event will trigger a call to this
    (via resize -> _init() -> set() -> image load -> image load -> bindEvents())
    and the 'hover' event type also triggers a 'mouseover' event having added an
    event listener for the same. This all means that each time a browser sends a
    resize event (which can happen on other events than a viewport width/height
    change) more event listeners are stacked, leading to significant CPU usage for
    no value.
    fredden committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    6bec772 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. Configuration menu
    Copy the full SHA
    693e366 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Merge branch '2.4-develop' into magnifier-resize-performance

    Gabriel da Gama authored Mar 31, 2021
    Configuration menu
    Copy the full SHA
    2bb781f View commit details
    Browse the repository at this point in the history