Fixed Unable to apply data patch issue after upgrade in 2.4 #29365

[ravi-chandra3197]

Description (*)

Fixed Unable to apply data patch issue #29365

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Magento 2.4 Upgrade issue Unable to apply data patch Magento\CatalogUrlRewrite\Setup\Patch\Data\UpdateUrlKeyForProducts #29365
2. Fixes Magento 2.4 upgrade fails if there is data under catalog_product_entity_varchar #29805

Manual testing scenarios (*)

1. Composer upgrade from 2.3.5-p1 to 2.4.0
2. php bin/magento setup:upgrade

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ravi-chandra3197]

@magento run all tests

[VladimirZaets]

@magento I am working on it

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

From Slack with @engcom-Alfa - he was able to reproduce this issue locally, but unfortunately, he didn't find exact steps to reproduce it.
@engcom-Alfa do you have any updates about that?

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Create several store views - en & de & fr;
2. Enable showing store code in the URL
3. Configure different URL keys for categories and for products for the DE & EN & FR versions;
4. Also were added different product attributes and other different combinations
   As result, we had several records by request:

mysql> SELECT COUNT(*)
    -> FROM catalog_product_entity_varchar cpev
    -> LEFT JOIN catalog_product_entity cpe on cpev.entity_id = cpe.entity_id
    -> WHERE cpe.entity_id IS NULL;

5. Try to upgrade;

Before: ❌ Upgrade Fail with the following error:

Unable to apply data patch Magento\CatalogUrlRewrite\Setup\Patch\Data\UpdateUrlKeyForProducts for module Magento_CatalogUrlRewrite. Original exception message: SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails (magento24.catalog_product_entity_varchar, CONSTRAINT CAT_PRD_ENTT_VCHR_ENTT_ID_CAT_PRD_ENTT_ENTT_ID FOREIGN KEY (entity_id) REFERENCES catalog_product_entity (entity_id) ON DELETE), query was: INSERT  INTO catalog_product_entity_varchar (value_id,value) VALUES (?, ?), (?, ?),....(?, ?) ON DUPLICATE KEY UPDATE value = VALUES(value)

After: ✔️ Upgrade finished successfully.

Also was tested general functionality and everything works as previously (expected)

[m2-assistant]

Hi @ravi-chandra3197, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.