'Ship Here' in CamelCase as that's how it is written elsewhere

[woutk88]

Description (*)

In the checkout shipping address modal the text in the primary button was written with a lowercase 'h'. On all other places, and in the translation files, it is written with a capital: 'Ship Here'. As a result, the button with the lowercase version 'Ship here' isn't translated.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] 'Ship Here' in CamelCase as that's how it is written elsewhere #28685: 'Ship Here' in CamelCase as that's how it is written elsewhere

[m2-assistant]

Hi @woutk88. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[rogyar]

@magento run Functional Tests CE

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7631 has been created to process this Pull Request

[magento-engcom-team]

Hi @ptylek, thank you for the review.
ENGCOM-7631 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Preconditions:

1. Has a simple product;
2. Logged as Customer to Storefront with at least 1 saved address;

Manual testing scenario:

1. Add translation for "Ship Here" in translation file; ("Ship Here","Ship Here (translated)" for ex.);
2. Add product to Cart;
3. Click on "Proceed to Checkout" button;
4. Click on "+ New Address" button;

Before: ✖️ The phrase was not translated

After: ✔️ The phrase was successfully translated

[engcom-Charlie]

@magento run all tests

[m2-assistant]

Hi @woutk88, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[engcom-Alfa]

@magento create issue