-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphQl] Gift Message coverage for cart item #28072
[GraphQl] Gift Message coverage for cart item #28072
Conversation
Hi @Usik2203. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Usik2203. Thank you for your collaboration. Please, check my comments below and feel free to proceed with the test coverage afterward.
Thank you!
app/code/Magento/GiftMessageGraphQl/Model/Resolver/GiftMessageItem.php
Outdated
Show resolved
Hide resolved
c6d6923
to
e915b4e
Compare
dev/tests/integration/testsuite/Magento/GiftMessage/_files/guest/quote_with_item_message.php
Show resolved
Hide resolved
2a59426
to
514891a
Compare
app/code/Magento/GiftMessageGraphQl/Model/Resolver/Cart/Item/GiftMessage.php
Outdated
Show resolved
Hide resolved
app/code/Magento/GiftMessageGraphQl/Model/Resolver/Cart/GiftMessage.php
Outdated
Show resolved
Hide resolved
app/code/Magento/GiftMessageGraphQl/Model/Resolver/Cart/Item/GiftMessage.php
Outdated
Show resolved
Hide resolved
dev/tests/api-functional/testsuite/Magento/GraphQl/GiftMessage/Cart/GiftMessageTest.php
Outdated
Show resolved
Hide resolved
@magento run all tests |
Hi @rogyar, thank you for the review. |
Hi @Usik2203, thank you for your contribution! |
Description (*)
This PR extends PR #27956 (Parent PR)
add coverage for cart items,
add mutation for updating gift message of cart items
add parameters to StoreConfig
This PR was mentioned for fixing failed Integration test
#259
#251
#246
Fixed Issues (if relevant)
Related Pull Requests
https://github.com/magento/partners-magento2-infrastructure/pull/3
Manual testing scenarios (*)
You can use this query for manual testing. You should take
maskedQuoteId
fromquote_id_mask
table.. on SimpleCartItem
.. on ConfigurableCartItem
.. on BundleCartItem
Mutation for updating gift messages for cart items