Update Zend.php

[mrploddy]

I came across a bug with Payment methods and I'm guessing it might also come up elsewhere.

I'm writing a test payment gateway for Sagepay form and in the declaration in the config.xml there was a spelling mistake in the payment code so that it didn't match up with the payment code declared in the Model eg

Config.xml

sagepayform
0
JuicyMedia_Sagepayform_Model_Sagepayform
<title>Sagepayform</title>
0

And in the Model -
class JuicyMedia_Sagepayform_Model_Sagepayform extends Mage_Payment_Model_Method_Abstract
{
protected $_code = 'sagepayform';

Because there was this spelling mistake it was creating an exception in /lib/Magento/Di/Zend.php

This pull request therefore is a way of making sure that Magento error's out properly with an exception instead of a PHP fatal error message.

This is only one specific use case but Im guessing there are other examples where this might occur.

[mrploddy]

Just come across another mistyped class name with exactly the same thing and I had missed out the Model in the class name so it was giving me a class not defined error. Should thefore add a class_exists too on to the check on $name to again make sure that Magento exceptions out gracefully.

[mrploddy]

eg if ($name == "" || $name == false || class_exists($name) == false) {
throw new Exception\RuntimeException("Invalid Class Name");
}

[mrploddy]

Just to clarify in the config.xml the payment code was sagepayformd and the model was sagepayform so it wasn't returning the model creating the PHP fatal error. There would be occasion when developers make mistakes in class namings and would cause Magento to error ungracefully in those instances.

[verklov]

Hello mrploddy,
Sorry for the delay with response.
Thank you for your contribution! Our team will review your pull request and respond as soon as our analysis is complete.

[verklov]

Hello mrploddy,
We cannot accept your pull request. Due to the changes we are making to the product, the code that is modified in the pull request does not exist in Magento any more.
Nevertheless, thank you for your contribution and participation in the Magento product development!