Add condition to avoid warning on calling file_exists() #2176
Conversation
fixes #2128 The warning was: "Warning: file_exists(): File name is longer than the maximum allowed path length on this platform (4096)…" The cause was: if we give the schema content instead of the schema filename as the second parameter of validateDomDocument we get this error if the schema is more longer than 4096 chars.
| @@ -274,7 +274,8 @@ public static function validateDomDocument( | |||
| $schema = self::$urnResolver->getRealPath($schema); | |||
| libxml_use_internal_errors(true); | |||
| try { | |||
| if (file_exists($schema)) { | |||
| // 4096 is the maximum length allowed by file_exists for the filename | |||
| if (strlen($schema) < 4096 && file_exists($schema)) { | |||
There was a problem hiding this comment.
This code will be removed, so the fix will not be required.
There was a problem hiding this comment.
Yes ok. But actually it doesn't work. So… If I put myself at the same point of view as you… Why not merging this and removing the code after? You just said you will remove it. But fixing problems until then is still a good idea, isn't it?
Seems to be a good idea, isn't it?
There was a problem hiding this comment.
I mean it's already removed and will be published with next publication. Merging this PR will just cause extra conflict.
How can this happen? |
|
@jacquesbh, I've looked into them before my comment. By my question I meant "what is the situation when such error occur except for human error?". As obviously you can put everything into everything and adding checks for all such cases is not really necessary. Now I understood this method was polymorhic and accepted not just schema file name but source as well. If you look into mainline, there is no more check for file presence: https://github.com/magento/magento2/blob/develop/lib/internal/Magento/Framework/Config/Dom.php#L290 Thus I believe problem disappeared by design and your fix is not applicable (but it fixed a real flaw overlooked in initial implementation, not just human error case). |
jacquesbh
deleted the
bugfix/MAGETWO-44227-xml-source-instead-of-xml-filename
branch
[Plankton] Prepare codebase for 2.2.4
ghost
mentioned this pull request
fixes #2128
The warning was: "Warning: file_exists(): File name is longer than the maximum allowed path length on this platform (4096)…"
The cause was: if we give the schema content instead of the schema filename as the second parameter of validateDomDocument
we get this error if the schema is more longer than 4096 chars.